New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.astropy: unbreak #107770
python3Packages.astropy: unbreak #107770
Conversation
Result of nixpkgs-review on x86_64 darwin:
|
pkgs/development/python-modules/astropy-extension-helpers/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/astropy-extension-helpers/default.nix
Outdated
Show resolved
Hide resolved
@jonringer: Comments addressed in force push. It appears that the package isn't advertising its version number correctly, which is causing at least one of the downstream packages to fail (astroquery).
|
I think it uses setuptools-scm to get the version from git tags. SETUPTOOLS_SCM_PRETEND_VERSION = version; to the expression: https://pypi.org/project/setuptools-scm/ |
Thanks for the tip, @Mic92. A bunch of commits later, I think I've fixed most of the astropy ecosystem now. 🤕 |
Result of 37 packages built:
|
1 similar comment
Result of 37 packages built:
|
Motivation for this change
Unbreak package. It appears to have been broken since it was upgraded from 4.0.3 -> 4.2 in 656348a https://hydra.nixos.org/build/133689349
I ran into a bit of difficulty.
(a) a separate helper library (https://github.com/astropy/extension-helpers) is necessary for installation, which appears to be totally different than the other astropy helper library we already have (https://github.com/astropy/astropy-helpers). I'm not sure if astropy-helpers is necessary anymore?
(b) I kept getting an inscrutable permission error with astropy-extension-helpers, which I've worked around with a patch.
(c) A number of packages appear to not build because they require older versions of astropy or their tests fail against this version of astropy, I'm not sure.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)On NixOS 86_64: