Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfce: update src to use new git repository #107742

Merged
merged 7 commits into from Dec 28, 2020
Merged

xfce: update src to use new git repository #107742

merged 7 commits into from Dec 28, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Dec 27, 2020 •
edited

Motivation for this change

upd.xfce xfce.xfce4-namebar-plugin = 0.3.1 -> 1.0.0
xfce.xfwm4: 4.14.5 -> 4.14.6
xfce.xfce4-whiskermenu-plugin: odd versions are not unstable
xfce.mousepad: odd versions are not unstable
xfce.orage: do not use mkXfceDerivation
xfce: use pname
xfce: update src to use new git repository

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
xfce: use pname
9ef6317
@romildo
xfce.orage: do not use mkXfceDerivation
e18817b 
The source is archived and unavailable at the new Xfce git repository
@romildo
xfce.mousepad: odd versions are not unstable
7918e97
@romildo
xfce.xfce4-whiskermenu-plugin: odd versions are not unstable
532133a
@romildo
xfce.xfwm4: 4.14.5 -> 4.14.6
afd2d87 
It seems that the tag xfwm4-4.14.5 was changed to xfwm4-4-14.5 upstream.
prusnak
prusnak requested changes Dec 27, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message from

xfce.xfce4-namebar-plugin = 0.3.1 -> 1.0.0

to

xfce.xfce4-namebar-plugin: 0.3.1 -> 1.0.0

@romildo
xfce.xfce4-namebar-plugin: 0.3.1 -> 1.0.0
237ea07 
- Update to version 1.0.0, based on gtk3
- Compile with vala 0.46
- Use pname
- Fix owner of git repository
- Add updateScript
@romildo
Copy link
Contributor Author

romildo commented Dec 27, 2020

Result of nixpkgs-review pr 107742 run on x86_64-linux 1

1 package marked as broken and skipped:
  • xfce.xfce4-vala-panel-appmenu-plugin
58 packages built:
  • lightdm_gtk_greeter
  • xfce.exo
  • xfce.garcon
  • xfce.gigolo
  • xfce.libxfce4ui
  • xfce.libxfce4util
  • xfce.mousepad
  • xfce.orage
  • xfce.parole
  • xfce.ristretto
  • xfce.terminal
  • xfce.thunar (xfce.thunar-bare)
  • xfce.thunar-archive-plugin
  • xfce.thunar-dropbox-plugin
  • xfce.thunar-volman
  • xfce.tumbler
  • xfce.xfburn
  • xfce.xfce4-appfinder
  • xfce.xfce4-battery-plugin
  • xfce.xfce4-clipman-plugin
  • xfce.xfce4-cpufreq-plugin
  • xfce.xfce4-cpugraph-plugin
  • xfce.xfce4-datetime-plugin
  • xfce.xfce4-dev-tools
  • xfce.xfce4-dict
  • xfce.xfce4-dockbarx-plugin
  • xfce.xfce4-embed-plugin
  • xfce.xfce4-eyes-plugin
  • xfce.xfce4-fsguard-plugin
  • xfce.xfce4-genmon-plugin
  • xfce.xfce4-hardware-monitor-plugin
  • xfce.xfce4-mailwatch-plugin
  • xfce.xfce4-mpc-plugin
  • xfce.xfce4-namebar-plugin
  • xfce.xfce4-netload-plugin
  • xfce.xfce4-notes-plugin
  • xfce.xfce4-notifyd
  • xfce.xfce4-panel
  • xfce.xfce4-power-manager
  • xfce.xfce4-pulseaudio-plugin
  • xfce.xfce4-screenshooter
  • xfce.xfce4-sensors-plugin
  • xfce.xfce4-session
  • xfce.xfce4-settings
  • xfce.xfce4-systemload-plugin
  • xfce.xfce4-taskmanager
  • xfce.xfce4-timer-plugin
  • xfce.xfce4-verve-plugin
  • xfce.xfce4-volumed-pulse
  • xfce.xfce4-weather-plugin
  • xfce.xfce4-whiskermenu-plugin
  • xfce.xfce4-windowck-plugin
  • xfce.xfce4-xkb-plugin
  • xfce.xfconf
  • xfce.xfdashboard
  • xfce.xfdesktop
  • xfce.xfwm4
  • xmonad_log_applet_xfce

@romildo romildo merged commit a6eab7f into NixOS:master Dec 28, 2020
@romildo romildo deleted the upd.xfce branch December 28, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @prusnak