Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3-balance-workspace: init at 1.8.3 #107740

Merged
merged 1 commit into from Dec 29, 2020
Merged

i3-balance-workspace: init at 1.8.3 #107740

merged 1 commit into from Dec 29, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Dec 27, 2020 •
edited

Motivation for this change

This creates a package for i3-balance-workspace, a program which re-balances windows and workspaces in the i3 window manager.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
How to test

You need to use an i3-compatible window manager.

Resize the windows un-evenly, then run:

nix-build -A i3-workspace-manager
./result/bin/i3_balance_workspace --scope workspace

The windows should be resized evenly.

I'm using this with a keybinding; it's working fine for me.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107740 run on x86_64-linux 1

1 package built:
  • i3-balance-workspace

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107740 run on x86_64-darwin 1

1 package failed to build:
  • i3-balance-workspace

minijackson
minijackson approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 107740 1

1 package were built:
  • i3-balance-workspace

Works fine on Sway!

stigtsp
stigtsp requested changes Dec 29, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also includes pkgs/misc/fish-plugins/fish-abbreviation-tips.nix is it intentional?

@pacien
Copy link
Contributor Author

pacien commented Dec 29, 2020

@stigtsp wrote:

This PR also includes pkgs/misc/fish-plugins/fish-abbreviation-tips.nix is it intentional?

It's not; woops!
Removed and amended; please review again.

stigtsp
stigtsp approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested OK on linux x64

Result of nixpkgs-review pr 107740 run on x86_64-linux 1

1 package built:
  • i3-balance-workspace

@stigtsp stigtsp merged commit eb300bb into NixOS:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@minijackson minijackson minijackson approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacien @SuperSandro2000 @stigtsp @minijackson