Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicacy: 2.3.0 -> 2.7.2 #107767

Merged
merged 1 commit into from Dec 30, 2020
Merged

duplicacy: 2.3.0 -> 2.7.2 #107767

merged 1 commit into from Dec 30, 2020

Conversation

Dyazz
Copy link
Contributor

@Dyazz Dyazz commented Dec 27, 2020 •
edited

Motivation for this change

This update brings a lot of news back-ends. You can now use OneDrive as a storage back-end.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ffinkdevs December 27, 2020 23:51
@fabaff
Copy link
Member

fabaff commented Dec 28, 2020

Result of nixpkgs-review pr 107767 run on x86_64-linux 1

1 package built:
  • duplicacy

fabaff
fabaff approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

[nix-shell:~/.cache/nixpkgs-review/pr-107767/results/duplicacy/bin]$ ./duplicacy 
NAME:
   duplicacy - A new generation cloud backup tool based on lock-free deduplication

USAGE:
   duplicacy [global options] command [command options] [arguments...]
   
VERSION:
   2.7.2 (unofficial)
   
COMMANDS:
   init         Initialize the storage if necessary and the current directory as the repository
   backup       Save a snapshot of the repository to the storage
[...]

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107767 run on x86_64-linux 1

1 package built:
  • duplicacy

@jonringer
Copy link
Contributor

@Dyazz thanks for making your first nixpkgs PR :)

jonringer
jonringer reviewed Dec 29, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind of small, but
To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

duplicacy: 2.3.0 -> 2.7.2

missing :, and should be lower case

otherwise, LGTM

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107767 run on x86_64-darwin 1

1 package built:
  • duplicacy

@Dyazz Dyazz changed the title Duplicacy 2.3.0 -> 2.7.2 duplicacy: 2.3.0 -> 2.7.2 Dec 29, 2020
@Dyazz
Copy link
Contributor Author

Dyazz commented Dec 29, 2020

kind of small, but
To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

duplicacy: 2.3.0 -> 2.7.2

missing :, and should be lower case

otherwise, LGTM

My bad. I reformatted the commit message.

Thanks for the reviews !

@jonringer
Copy link
Contributor

My bad. I reformatted the commit message.

Thanks for the reviews !

The title was changed, but the commit is the same. Need to do:

git commit --amend
# edit subject line
# save
git push ... ... --force

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 107767 1

1 package built:
  • duplicacy

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/312

@SuperSandro2000 SuperSandro2000 merged commit cf35082 into NixOS:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@fabaff fabaff fabaff approved these changes

@thiagokokada thiagokokada thiagokokada approved these changes

@ffinkdevs ffinkdevs Awaiting requested review from ffinkdevs

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Dyazz @fabaff @SuperSandro2000 @jonringer @thiagokokada @nixos-discourse @Janik-Haag