Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meslo-lgs-nf: init at git-2020-03-22 #107745

Merged
merged 1 commit into from Dec 28, 2020
Merged

meslo-lgs-nf: init at git-2020-03-22 #107745

merged 1 commit into from Dec 28, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Dec 27, 2020

Motivation for this change

https://github.com/romkatv/powerlevel10k#meslo-nerd-font-patched-for-powerlevel10k

cc @Hexa

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107745 run on x86_64-linux 1

1 package built:
  • meslo-lgs-nf

@bbigras @SuperSandro2000
meslo-lgs-nf: init at 2020-03-22
4e9e2ed 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@bbigras
Copy link
Contributor Author

bbigras commented Dec 27, 2020

Thanks @SuperSandro2000 !

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107745 run on x86_64-linux 1

1 package built:
  • meslo-lgs-nf

@bbigras
Copy link
Contributor Author

bbigras commented Dec 28, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 28, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107745 run on x86_64-darwin 1

1 package built:
  • meslo-lgs-nf

@SuperSandro2000 SuperSandro2000 merged commit b1e4174 into NixOS:master Dec 28, 2020
@bbigras bbigras deleted the meslolgs-nf branch December 28, 2020 23:31
@bbigras
Copy link
Contributor Author

bbigras commented Dec 28, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@bennyandresen bennyandresen Awaiting requested review from bennyandresen

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbigras @SuperSandro2000