Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyparsing: 2.4.6 -> 2.4.7 #107791

Merged
merged 1 commit into from Dec 28, 2020
Merged

python3Packages.pyparsing: 2.4.6 -> 2.4.7 #107791

merged 1 commit into from Dec 28, 2020

Conversation

kini
Copy link
Member

@kini kini commented Dec 28, 2020

Motivation for this change

Bump to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kamadorueda December 28, 2020 12:25
@kini kini mentioned this pull request Dec 28, 2020
Merged
10 tasks
@fabaff fabaff mentioned this pull request Dec 28, 2020
Closed
10 tasks
prusnak
prusnak requested changes Dec 28, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please change the commit message to python3Packages.pyparsing

  2. Please target staging branch as this causes a massive rebuild.

@kini kini changed the base branch from master to staging December 28, 2020 13:52
@kini
Copy link
Member Author

kini commented Dec 28, 2020

  1. Please change the commit message to python3Packages.pyparsing
  2. Please target staging branch as this causes a massive rebuild.

Done. Sorry for the noise @ other maintainers who were pinged while I was switching target branches.

@kini kini changed the title python: pyparsing: 2.4.6 -> 2.4.7 python3Packages.pyparsing: 2.4.6 -> 2.4.7 Dec 28, 2020
@ofborg ofborg bot added 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: qt/kde 8.has: changelog 8.has: documentation and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: erlang labels Dec 28, 2020
@kini kini requested a review from prusnak December 28, 2020 14:40
@SuperSandro2000
Copy link
Member

  1. Please change the commit message to python3Packages.pyparsing
  2. Please target staging branch as this causes a massive rebuild.

Done. Sorry for the noise @ other maintainers who were pinged while I was switching target branches.

Known issue. A fix for this is in the making.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.requests

@kini
Copy link
Member Author

kini commented Dec 28, 2020

@GrahamcOfBorg build python3Packages.requests

Did you perhaps mean this to be python3Packages.pyparsing, or am I missing something?

@prusnak
Copy link
Member

prusnak commented Dec 28, 2020 •
edited

Did you perhaps mean this to be python3Packages.pyparsing, or am I missing something?

requests have pyparsing as (indirect) dependency, so I guess Jonathan wants to check whether it still builds

@jonringer
Copy link
Contributor

yea, a successful requests build means that sphnix, pytest, and a few other critical libraries all work. Usually doesn't take too long, but looks like staging just had the gcc10 changes applied, so it has to rebuild from stdenv

@jonringer jonringer merged commit eab1bfb into NixOS:staging Dec 28, 2020
@kini kini deleted the pyparsing/bump-2.4.7 branch December 28, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@kamadorueda kamadorueda Awaiting requested review from kamadorueda

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kini @SuperSandro2000 @jonringer @prusnak