Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icu: 67.1 -> 68.2 #107774

Merged
merged 2 commits into from Feb 13, 2021
Merged

icu: 67.1 -> 68.2 #107774

merged 2 commits into from Feb 13, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 28, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor Author

marsam commented Dec 30, 2020

@GrahamcOfBorg build tesseract
@GrahamcOfBorg build postgresql

@FRidh
Copy link
Member

FRidh commented Jan 4, 2021

postgres failed it seems

@marsam
Copy link
Contributor Author

marsam commented Feb 13, 2021

postgres failed it seems

PostgreSQL fixed its build with ICU 68 in the latest bump #112853
@GrahamcOfBorg build nodejs
@GrahamcOfBorg build tesseract
@GrahamcOfBorg build postgresql

@ofborg ofborg bot requested a review from lovek323 February 13, 2021 18:04
@marsam
Copy link
Contributor Author

marsam commented Feb 13, 2021

@GrahamcOfBorg build nodejs
@GrahamcOfBorg build tesseract
@GrahamcOfBorg build postgresql

@marsam marsam merged commit b24c0ac into NixOS:staging Feb 13, 2021
@marsam marsam deleted the update-icu branch February 13, 2021 20:08
@ajs124 ajs124 mentioned this pull request Feb 28, 2021
Merged
10 tasks
@ghost
Copy link

ghost commented Mar 3, 2021

This broke the nodejs-10_x build.

@ghost ghost mentioned this pull request Mar 3, 2021
Merged
10 tasks
@ento ento mentioned this pull request Mar 15, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @FRidh