Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifiStable: 5.14.23 -> 6.0.43 #107797

Merged
2 commits merged into from Dec 28, 2020
Merged

unifiStable: 5.14.23 -> 6.0.43 #107797

2 commits merged into from Dec 28, 2020

Conversation

elseym
Copy link
Member

@elseym elseym commented Dec 28, 2020 •
edited

Motivation for this change
  • update the unifi controller to the latest version. see changelog.
  • remove unifiBeta because there is no publicly available beta version of this software
Things done
  • package software version 6.x as unifi6
  • package software version 5.x as unifi5
  • alias unifi6 as unifi and unifiStable for backward compatibility
    (see discussion for details)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elseym
Copy link
Member Author

elseym commented Dec 28, 2020 •
edited

@Patryk27 @lukegb @petabyteboy since you participated in previous PRs regarding this package: is it ok for you if we remove unifiBeta in order to not maintain a package for a non-public beta version of an unfree piece of software?

@Patryk27
Copy link
Member

@elseym: sure - if 6.0 hit stable, then imho there's no point in keeping that beta version around anymore :-)

@ghost
Copy link

ghost commented Dec 28, 2020

6.0 was declared stable a while ago already. I'm okay with changing the names. Some people I know will not be happy about the 5.14.x branch being dropped, but that's Ubnt's decision and not ours.

@Patryk27
Copy link
Member

Some people I know will not be happy about the 5.14.x branch being dropped, but that's Ubnt's decision and not ours.

If there are important changes in-between, maybe we could provide unifi5 that's pinned to 5.14.23? (same way there's a separate package for python27 + python3)

@SuperSandro2000
Copy link
Member

Please adjust all-packages.nix to fix the eval error.

@ghost
Copy link

ghost commented Dec 28, 2020

Can you put the unifiStable = unifi6 in pkgs/top-level/aliases.nix instead? This will make sure it's not used in nixpkgs itself anymore.

@elseym
Copy link
Member Author

elseym commented Dec 28, 2020

thanks for your input. 😄

i could not find any information about possible LTS bumps from upstream, afaics 5.6.x is still LTS. i also don't know whether upstream plans to further support the 5.x branch apart from the (really old) LTS release.
the only other current release seems to be 6.0.x, which imho we should maintain as unifiStable (possibly rename it to unifi for the next release?).
i added a second commit renaming the packages. could this be an appropriate solution?

@elseym
unifi: rename packages
0bb74ff 
- renames unifiStable to unifi5
- renames unifiBeta to unifi6
- aliases unifi to unifi6
- aliases unifiStable to unifi6 for backward compatibility
@ofborg ofborg bot requested review from erictapen and globin December 28, 2020 15:32
@ghost ghost merged commit bee49df into NixOS:master Dec 28, 2020
@elseym elseym deleted the bump-unifi branch December 28, 2020 16:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen Awaiting requested review from erictapen

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elseym @Patryk27 @SuperSandro2000