Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.camlzip: 1.07 -> 1.10 #107750

Merged
merged 1 commit into from Dec 29, 2020
Merged

ocamlPackages.camlzip: 1.07 -> 1.10 #107750

merged 1 commit into from Dec 29, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Dec 28, 2020 •
edited

@GrahamcOfBorg build framac google-drive-ocamlfuse opa ocamlPackages.sawja ocamlPackages.phylogenetics

vbgl
vbgl requested changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks opa.

@freezeboy
Copy link
Contributor Author

Should work now for opa

@vbgl vbgl merged commit 722c01a into NixOS:master Dec 29, 2020
@freezeboy freezeboy deleted the update-camlzip branch December 29, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @vbgl