Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 65f65ad2: Don't try to construct a std::string from nullptr #8449

Merged
merged 1 commit into from Dec 27, 2020
Merged

Fix 65f65ad2: Don't try to construct a std::string from nullptr #8449

merged 1 commit into from Dec 27, 2020

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Dec 27, 2020

Motivation / Problem

Downloading online content caused a crash

Description

Crash caused by trying to construct a std::string from a nullptr
Also remove an unnecessary conversion.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro requested a review from michicc December 27, 2020 18:12
glx22
glx22 previously approved these changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong commit references (should be b408fe7), otherwise seems correct.

glx22
glx22 approved these changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LordAro LordAro merged commit e0161cf into OpenTTD:master Dec 27, 2020
@LordAro LordAro deleted the fix-download branch December 27, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

@michicc michicc Awaiting requested review from michicc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LordAro @glx22