Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palemoon: 28.16.0 -> 28.17.0 #107329

Merged
1 commit merged into from Dec 27, 2020
Merged

palemoon: 28.16.0 -> 28.17.0 #107329

1 commit merged into from Dec 27, 2020

Conversation

OPNA2608
Copy link
Contributor

Motivation for this change

Security issues addressed: CVE-2020-26978 and CVE-2020-35112.
Unified XUL Platform Mozilla Security Patch Summary: 2 fixed, 1 deferred to the next release, 16 not applicable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from AndersonTorres December 21, 2020 15:59
@ghost ghost added the 1.severity: security label Dec 21, 2020
@ghost
Copy link

ghost commented Dec 21, 2020

This fails to build for me:

pbb@onyx:~]$ nix build -f https://github.com/OPNA2608/nixpkgs/archive/update/palemoon-28.17.0/21.03.tar.gz palemoon
builder for '/nix/store/rvw0zwiqndjccd5yxy9hylhv0aa7sv3k-palemoon-28.17.0.drv' failed with exit code 2; last 10 log lines:
  78 0:25.67(B cd testlib; /nix/store/6mic0pcmp4va0ghx7hn5wl3jl4ll4h2q-gnumake-4.3/bin/make private_export
  78 0:25.68(B There are no private exports.
  78 0:25.68(B There are no private exports.
  78 0:25.68(B There are no private exports.
  78 0:36.70(B make[3]: *** [/build/source/platform/config/recurse.mk:33: export] Error 2
  78 0:36.70(B make[2]: *** [/build/source/platform/config/rules.mk:494: default] Error 2
  78 0:36.70(B make[1]: *** [/build/source/client.mk:406: realbuild] Error 2
  78 0:36.70(B make: *** [client.mk:164: build] Error 2
  78 0:36.72(B 0 compiler warnings present.
[0 built (1 failed)]
error: build of '/nix/store/rvw0zwiqndjccd5yxy9hylhv0aa7sv3k-palemoon-28.17.0.drv' failed

Full log at https://termbin.com/3l4u

@OPNA2608
Copy link
Contributor Author 

8 0:23.04 cd pkix; /nix/store/6mic0pcmp4va0ghx7hn5wl3jl4ll4h2q-gnumake-4.3/bin/make private_export
8 0:23.06 cd certsel; /nix/store/6mic0pcmp4va0ghx7hn5wl3jl4ll4h2q-gnumake-4.3/bin/make private_export
8 0:23.08 Traceback (most recent call last):
8 0:23.08   File "/build/source/platform/config/pythonpath.py", line 56, in <module>
8 0:23.08     main(sys.argv[1:])
8 0:23.08   File "/build/source/platform/config/pythonpath.py", line 48, in main
8 0:23.08     execfile(script, frozenglobals)
8 0:23.08   File "/build/source/platform/python/mozbuild/mozbuild/action/xpidl-process.py", line 20, in <module>
8 0:23.08     from xpidl.typelib import write_typelib
8 0:23.08   File "/build/source/platform/xpcom/idl-parser/xpidl/typelib.py", line 13, in <module>
8 0:23.08     import xpt
8 0:23.08 EOFError: EOF read where object expected
8 0:23.08 Traceback (most recent call last):
8 0:23.08   File "/build/source/platform/config/pythonpath.py", line 56, in <module>
8 0:23.08     main(sys.argv[1:])
8 0:23.08   File "/build/source/platform/config/pythonpath.py", line 48, in main
8 0:23.08     execfile(script, frozenglobals)
8 0:23.08   File "/build/source/platform/python/mozbuild/mozbuild/action/xpidl-process.py", line 20, in <module>
8 0:23.08     from xpidl.typelib import write_typelib
8 0:23.08   File "/build/source/platform/xpcom/idl-parser/xpidl/typelib.py", line 13, in <module>
8 0:23.08     import xpt
8 0:23.08 EOFError: EOF read where object expected
8 0:23.09 make[6]: *** [Makefile:45: ../../../dist/bin/components/autoconfig.xpt] Error 1
8 0:23.09 make[6]: *** Waiting for unfinished jobs....
8 0:23.09 make[6]: *** [Makefile:45: ../../../dist/bin/components/content_html.xpt] Error 1

Cannot reproduce, builds past this point on 2 different systems with nix-build & nixpkgs-review, and on ofborg. Is this reproducible on your end, perhaps with a lower amount of build cores too? See build requisites as well.

Prerequisites

[…]

  • Plenty of free disk space
  • At least 6 GB RAM free depending on number of processor cores (limit using the mk_add_options MOZ_MAKE_FLAGS="-jN" option)

@Artturin
Copy link
Member

Result of nixpkgs-review pr 107329 run on x86_64-linux 1

1 package built:
  • palemoon

can launch

@ghost
Copy link

ghost commented Dec 27, 2020

After freeing up my RAM a bit I could build and launch it as well. Thanks for the hint.

@ghost ghost merged commit b8f2c6f into NixOS:master Dec 27, 2020
OPNA2608 added a commit to OPNA2608/nixpkgs that referenced this pull request Dec 29, 2020
@OPNA2608
palemoon: 28.16.0 -> 28.17.0 (NixOS#107329)
7c5cba5 
(cherry picked from commit b8f2c6f)
@OPNA2608 OPNA2608 mentioned this pull request Dec 29, 2020
Merged
10 tasks
@OPNA2608
Copy link
Contributor Author

Backport to 20.09: #107882

@OPNA2608 OPNA2608 mentioned this pull request Feb 12, 2021
Merged
10 tasks
@OPNA2608 OPNA2608 mentioned this pull request Aug 20, 2021
Merged
1 task
@OPNA2608 OPNA2608 deleted the update/palemoon-28.17.0/21.03 branch September 27, 2022 17:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OPNA2608 @Artturin