Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calamares: 3.2.17.1 -> 3.2.35.1 #107749

Merged
merged 1 commit into from Dec 28, 2020
Merged

calamares: 3.2.17.1 -> 3.2.35.1 #107749

merged 1 commit into from Dec 28, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from manveru December 27, 2020 19:43
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107749 run on x86_64-linux 1

1 package built:
  • calamares

cmake is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

patchPhase should not be overridden, use postPatch instead.

@freezeboy
Copy link
Contributor Author

Thanks for the review

@marsam marsam merged commit 710e413 into NixOS:master Dec 28, 2020
@freezeboy freezeboy deleted the update-calamares branch December 29, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @SuperSandro2000 @marsam