Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neochat: re-add kitemmodels and qtgraphicaleffects to build inputs #107765

Merged
merged 1 commit into from Dec 28, 2020
Merged

neochat: re-add kitemmodels and qtgraphicaleffects to build inputs #107765

merged 1 commit into from Dec 28, 2020

Conversation

mjlbach
Copy link
Contributor

@mjlbach mjlbach commented Dec 27, 2020 •
edited

Motivation for this change

During cleanups, kitemmodels and qtgraphicaleffects were removed from the build-inputs, these are needed to launch neochat on non-nixos systems

cc @peterhoeg @SuperSandro2000 @lovesegfault

❯ nixGLNvidia ./result/bin/neochat
Gtk-Message: 14:52:46.544: Failed to load module "canberra-gtk-module"
Gtk-Message: 14:52:46.544: Failed to load module "pk-gtk-module"
Gtk-Message: 14:52:46.545: Failed to load module "canberra-gtk-module"
Gtk-Message: 14:52:46.545: Failed to load module "pk-gtk-module"
QQmlApplicationEngine failed to load component
qrc:/qml/main.qml:19:1: Type Kirigami.ApplicationWindow unavailable
file:///nix/store/1vvhlf5lyc83xapin99qc4vw93nspdf1-kirigami2-5.76.0/lib/qt-5.15.2/qml/org/kde/kirigami.2/styles/org.kde.desktop/ApplicationWindow.qml:12:1: Type Base.ApplicationWindow unavailable
file:///nix/store/1vvhlf5lyc83xapin99qc4vw93nspdf1-kirigami2-5.76.0/lib/qt-5.15.2/qml/org/kde/kirigami.2/ApplicationWindow.qml:10:1: module "QtGraphicalEffects" is not installed

❯ nixGLNvidia ./result/bin/neochat
Gtk-Message: 14:53:10.875: Failed to load module "canberra-gtk-module"
Gtk-Message: 14:53:10.875: Failed to load module "pk-gtk-module"
Gtk-Message: 14:53:10.876: Failed to load module "canberra-gtk-module"
Gtk-Message: 14:53:10.876: Failed to load module "pk-gtk-module"
QQmlApplicationEngine failed to load component
qrc:/qml/main.qml:118:20: Type RoomDrawer unavailable
qrc:/imports/NeoChat/Panel/RoomDrawer.qml:13:1: module "org.kde.kitemmodels" is not installed
Things done

re-add kitemmodels and qtgraphicaleffects to build inputs

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mjlbach
Copy link
Contributor Author

mjlbach commented Dec 27, 2020

Also see: https://invent.kde.org/network/neochat/-/commit/93e0a2b2f64fb9d8e2b7008a4fad67e1917d0f06

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107765 run on x86_64-linux 1

1 package built:
  • neochat

@peterhoeg
Copy link
Member

I didn't try this on !nixos - thanks @mjlbach

@peterhoeg peterhoeg merged commit 3325053 into NixOS:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjlbach @SuperSandro2000 @peterhoeg