Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.cloudscraper: init at 1.2.52 #107796

Merged
merged 1 commit into from Jan 12, 2021

Conversation

kini
Copy link
Member

@kini kini commented Dec 28, 2020

Motivation for this change

New package. Tests disabled for now since they pull in a lot of stuff. This PR depends on #107791.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title and commit message to python3Packages.cloudscraper: init at 1.2.50

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107796 run on x86_64-linux 1

3 packages failed to build:
  • python37Packages.cloudscraper
  • python38Packages.cloudscraper
  • python39Packages.cloudscraper
ERROR: Could not find a version that satisfies the requirement pyparsing>=2.4.7 (from cloudscraper)
ERROR: No matching distribution found for pyparsing>=2.4.7

@kini kini changed the title python: cloudscraper: init at 1.2.50 python3Packages.cloudscraper: init at 1.2.50 Dec 28, 2020
@kini kini force-pushed the cloudscraper/init branch 2 times, most recently from bbab39b to 5c46fd9 Compare January 11, 2021 04:17
@kini kini changed the title python3Packages.cloudscraper: init at 1.2.50 python3Packages.cloudscraper: init at 1.2.52 Jan 11, 2021
@kini kini marked this pull request as ready for review January 11, 2021 15:30
@kini
Copy link
Member Author

kini commented Jan 11, 2021

Please change the title and commit message to python3Packages.cloudscraper: init at 1.2.50

Done (updated to 1.2.52).

Package builds on Python 3.7, 3.8, and 3.9, and PyPy 3. On Python 3.6, the dependency cffi is broken on master.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107796 run on x86_64-darwin 1

3 packages built:
  • python37Packages.cloudscraper
  • python38Packages.cloudscraper
  • python39Packages.cloudscraper

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107796 run on x86_64-linux 1

3 packages built:
  • python37Packages.cloudscraper
  • python38Packages.cloudscraper
  • python39Packages.cloudscraper

@SuperSandro2000 SuperSandro2000 merged commit 8c89519 into NixOS:master Jan 12, 2021
@kini kini deleted the cloudscraper/init branch January 12, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants