New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with different fonts #663
Conversation
Thanks @garbas! Sora: hard to read because of the details and proportions tl;dr my recommendation Primary: Open Sans i'm not sure if the difference between Primary and Secondary is big enough. so if we want to decide on this, i want to have a final look in a preview there are also other combinations that would not bother me |
i think that looks very good and consistent. you don't notice some special font, but just read the content
i would like to improve the font weight in a next step. the body seem to use the thin version which is harder to reed than regular. try how regular would look
Am 28. Dezember 2020 23:08:12 MEZ schrieb "github-actions[bot]" <notifications@github.com>:
…<!-- NETLIFY DEPLOY COMMENT GENERATED BY ACTIONS_NETLIFY -->>
🚀 Deployed on
https://5fea573bf88342390af2db09--nixos-homepage.netlify.app>
>
-- >
You are receiving this because your review was requested.>
Reply to this email directly or view it on GitHub:>
#663 (comment)
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
|
I think the first one is the best choice, readable and modern. |
@hugolgst since the font combinations are not numbered can you copy paste the option that you selected. Also if you can expend a bit on why your choice is readable and modern? |
This combination: I like it because the titles do not use serif fonts and I find it a bit easier to read. |
Just noticed a small issue: when the selection produces an empty set then the side bar with the facet selectors vanishes and the user is stuck on an empty page without the ability to go back. |
My favorite is: |
I'm also in favor of Primary: Roboto option. I'm going to go ahead and implement it, since this has been open for some now and it would be nice to finalize this. |
I'm also fine with it. |
Building process of site-styles is now handled with Makefile, this offers more incremental build support (aka faster developing cycles)
29ec9dd
to
f07a2f8
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/marketing-team-meeting-minutes-17-18-19/11092/1 |
@samueldr fixed |
This PR tries to explore different font combinations. This was one of the items on the TODO list after the redesign.
There are 3 fonts we need to select:
1.) Primary: font used for general text
2.) Secondary: font used for titles
3.) Monospace: font used for code examples
If you wish to suggest new combination please write in the comments.
Font combinations
Secondary: Sora
Monospace: Fira Mono
Secondary: Zilla Slab
Monospace: Fira Mono
Secondary: Source Sans Pro
Monospace: Fira Mono
Secondary: Overpass
Monospace: Fira Mono
Secondary: Source Sans Pro
Monospace: Fira Mono
Secondary: Overpass
Monospace: Fira Mono
Secondary: Source Sans Pro
Monospace: Fira Mono
Secondary: Zilla Slab
Monospace: Fira Mono
Secondary: Lato
Monospace: Fira Mono
Secondary: Meriweather
Monospace: Fira Mono
Secondary: Lato
Monospace: Fira Mono
As always please keep the conversation civil especially when it comes to design. What looks good for somebody might not look good for somebody else. It is fine that you tell what you like and dislike, but it is even better if you tell why you dislike something (eg. not readable, ...). Thank you in advance.
fixes #508