Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disfetch: init at 1.12 #107788

Closed
wants to merge 0 commits into from
Closed

disfetch: init at 1.12 #107788

wants to merge 0 commits into from

Conversation

q60
Copy link
Contributor

@q60 q60 commented Dec 28, 2020

Motivation for this change

Disfetch is another *nix distro fetching program, but less complex. It is based on several principles

  • less code, more efficiency, more readability
  • simplicity
  • logos must be only 8 rows
  • using only coreutils, other built-ins, bash and nothing third-party
  • showing only main and needed system information

https://github.com/llathasa-veleth/disfetch

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 28, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits together.

maintainers/maintainer-list.nix Outdated
@@ -9275,6 +9275,12 @@
githubId = 2212422;
name = "uwap";
};
v = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this into a separate commit with the message maintainers: add veleth and maybe change your name to veleth.

pkgs/tools/misc/disfetch/default.nix Outdated
@@ -0,0 +1,27 @@
{ stdenv
, lib
, fetchFromGitHub }: stdenv.mkDerivation rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, fetchFromGitHub }: stdenv.mkDerivation rec {
, fetchFromGitHub }:
stdenv.mkDerivation rec {

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107788 run on x86_64-linux 1

1 package built:
  • disfetch

@q60
Copy link
Contributor Author

q60 commented Dec 28, 2020

Hi, should I close this pull request then make a new one with right steps? Sorry for incompetence.

@q60 q60 closed this Dec 28, 2020
@SuperSandro2000
Copy link
Member

Hi, should I close this pull request then make a new one with right steps?

No, you should do the changes and force push them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@q60 @SuperSandro2000 @Janik-Haag