Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptraf-ng: 1.1.4 -> 1.2.1 #107793

Merged
merged 1 commit into from Jan 3, 2021
Merged

iptraf-ng: 1.1.4 -> 1.2.1 #107793

merged 1 commit into from Jan 3, 2021

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Dec 28, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Dec 28, 2020

Result of nixpkgs-review pr 107793 run on x86_64-linux 1

1 package built:
  • iptraf-ng

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107793 run on x86_64-linux 1

1 package built:
  • iptraf-ng

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like files end up in $out/homeless-shelter/

[nix-shell:~/.cache/nixpkgs-review/pr-107793]$ find results/iptraf-ng/
results/iptraf-ng/
results/iptraf-ng/homeless-shelter
results/iptraf-ng/homeless-shelter/share
results/iptraf-ng/homeless-shelter/share/man
results/iptraf-ng/homeless-shelter/share/man/man8
results/iptraf-ng/homeless-shelter/share/man/man8/iptraf-ng.8
results/iptraf-ng/homeless-shelter/sbin
results/iptraf-ng/homeless-shelter/sbin/iptraf-ng

@devhell
Copy link
Contributor Author

devhell commented Jan 3, 2021

Seems like files end up in $out/homeless-shelter/

[nix-shell:~/.cache/nixpkgs-review/pr-107793]$ find results/iptraf-ng/
results/iptraf-ng/
results/iptraf-ng/homeless-shelter
results/iptraf-ng/homeless-shelter/share
results/iptraf-ng/homeless-shelter/share/man
results/iptraf-ng/homeless-shelter/share/man/man8
results/iptraf-ng/homeless-shelter/share/man/man8/iptraf-ng.8
results/iptraf-ng/homeless-shelter/sbin
results/iptraf-ng/homeless-shelter/sbin/iptraf-ng

Sorry, I missed that.

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK on linux x64

New src url looks legit, same used in Arch

@stigtsp stigtsp merged commit bc1b117 into NixOS:master Jan 3, 2021
@devhell devhell deleted the iptraf-ng branch January 3, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants