Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: fix Exec paths in further desktop files #107761

Merged
merged 1 commit into from Dec 28, 2020
Merged

skypeforlinux: fix Exec paths in further desktop files #107761

merged 1 commit into from Dec 28, 2020

Conversation

eliasp
Copy link
Member

@eliasp eliasp commented Dec 27, 2020 •
edited

The Exec= paths in share/applications/skypeforlinux-share.desktop
and share/kservices5/ServiceMenus/skypeforlinux.desktop still pointed
to /usr/bin/skypeforlinux.
Apply substituteInPlace on them as well.

Motivation for this change

Ensure the "Share with Skype" functionality works in all DEs.

Things done
  • compared Exec= lines in *.desktop files before and after this modification.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eliasp
skypeforlinux: fix Exec paths in further desktop files
71f2101 
The `Exec=` paths in `share/applications/skypeforlinux-share.desktop`
and `share/kservices5/ServiceMenus/skypeforlinux.desktop` still pointed
to `/usr/bin/skypeforlinux`.
Apply `substituteInPlace` on them as well.
SuperSandro2000
SuperSandro2000 reviewed Dec 28, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hw many desktop files do they have? 😂

jraygauthier
jraygauthier approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@jraygauthier jraygauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107761 run on x86_64-linux 1

1 package built:
  • skypeforlinux

@SuperSandro2000 SuperSandro2000 merged commit 3f87066 into NixOS:master Dec 28, 2020
@eliasp
Copy link
Member Author

eliasp commented Dec 29, 2020

FYI, the latest recommendation is to not use absolute paths in the Exec= directive. Rationale: .desktop files are often copied to $HOME/... for auto-starting, which means they bit-rot...

@bjornfor Good point! Stumbled upon some stale desktop files (next to also a few symlinks) in my user's autostart folder as well and wondered, whether I actually copied them there at some point in the past. So if actually some apps copy their own desktop file to enable autostart, this makes perfect sense.

Will follow up with a fix for this issue 😄

@eliasp eliasp deleted the skypeforlinux-exec-path branch December 29, 2020 17:15
@eliasp eliasp mentioned this pull request Dec 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@prusnak prusnak prusnak approved these changes

@jraygauthier jraygauthier jraygauthier approved these changes

@PanAeon PanAeon Awaiting requested review from PanAeon

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eliasp @SuperSandro2000 @prusnak @bjornfor @jraygauthier