gnome3.gnome-boxes: remove xen as dependency #108716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❯ nix-shell -p nixpkgs-review --run "nixpkgs-review pr 108716"
this path will be fetched (0.04 MiB download, 0.15 MiB unpacked):
/nix/store/djjcy5s3073x2p1jnnn8gmdpbabw1gx8-nixpkgs-review-2.5.0
copying path '/nix/store/djjcy5s3073x2p1jnnn8gmdpbabw1gx8-nixpkgs-review-2.5.0' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/108716/head:refs/nixpkgs-review/1
remote: Enumerating objects: 55, done.
remote: Counting objects: 100% (55/55), done.
remote: Compressing objects: 100% (23/23), done.
remote: Total 66 (delta 43), reused 32 (delta 32), pack-reused 11
Unpacking objects: 100% (66/66), 90.55 KiB | 337.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
d9dba88d08a..e0f22de78a6 master -> refs/nixpkgs-review/0
+ d2a0638087a...4cd39c9c149 refs/pull/108716/head -> refs/nixpkgs-review/1 (forced update)
$ git worktree add /home/thiago/.cache/nixpkgs-review/pr-108716/nixpkgs e0f22de78a6c0a5ec3582211b05fb2b6512d4e77
Preparing worktree (detached HEAD e0f22de78a6)
HEAD is now at e0f22de78a6 Merge pull request #107894 from JamieMagee/advantage_air
$ nix-env -f /home/thiago/.cache/nixpkgs-review/pr-108716/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 4cd39c9c149fafb392ea923449226473c054128b
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/thiago/.cache/nixpkgs-review/pr-108716/nixpkgs -qaP --xml --out-path --show-trace --meta
1 package updated:
gnome-boxes
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/thiago/.cache/nixpkgs-review/pr-108716/build.nix
Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/108716
1 package built:
gnome3.gnome-boxes |
ofborg
bot
added
the
6.topic: GNOME
|
Result of 1 package built:
I couldn't create a VM in UI but I think this is mostly the fault of |
thiagokokada
approved these changes
Jan 8, 2021
|
@thiagokokada it worked for me and it was able to load a VM already created. |
worldofpeace
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Xen is not necessary to build gnome-boxes. there is no Xen as dependency in Gnome-boxes Flatpak, Debian Package, neither in Arch package.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)