Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.geopy: unstable-2019-11-10 -> 2.1.0 #108663

Merged
merged 3 commits into from Jan 15, 2021
Merged

python3Packages.geopy: unstable-2019-11-10 -> 2.1.0 #108663

merged 3 commits into from Jan 15, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 7, 2021

Motivation for this change

Update to latest upstream release 2.1.0

Change log: https://geopy.readthedocs.io/en/stable/changelog_2xx.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Jan 7, 2021

Result of nixpkgs-review pr 108663 1

3 packages built:
  • python37Packages.geopy
  • python38Packages.geopy
  • python39Packages.geopy

GuillaumeDesforges
GuillaumeDesforges approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@GuillaumeDesforges GuillaumeDesforges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

LGTM :)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108663 run on x86_64-linux 1

3 packages built:
  • python37Packages.geopy
  • python38Packages.geopy
  • python39Packages.geopy

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108663 run on x86_64-darwin 1

3 packages failed to build and are new build failures:
  • python37Packages.geopy
  • python38Packages.geopy
  • python39Packages.geopy 
diff --git a/pkgs/development/python-modules/geopy/default.nix b/pkgs/development/python-modules/geopy/default.nix
index 6976b080390..9c4e9c03d57 100644
--- a/pkgs/development/python-modules/geopy/default.nix
+++ b/pkgs/development/python-modules/geopy/default.nix
@@ -30,6 +30,8 @@ buildPythonPackage rec {
   pytestFlagsArray = [ "--ignore test/geocoders/" ];
   pythonImportsCheck = [ "geopy" ];

+  __darwinAllowLocalNetworking = true;
+
   meta = with stdenv.lib; {
     homepage = "https://github.com/geopy/geopy";
     description = "Python Geocoding Toolbox";

@fabaff fabaff force-pushed the geopy branch 2 times, most recently from c513b50 to 831985a Compare January 13, 2021 23:05
@fabaff
Copy link
Member Author

fabaff commented Jan 13, 2021

Darwin patch added. Thanks.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108663 run on x86_64-darwin 1

3 packages built:
  • python37Packages.geopy
  • python38Packages.geopy
  • python39Packages.geopy

@SuperSandro2000 SuperSandro2000 merged commit 6212342 into NixOS:master Jan 15, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108663 run on x86_64-linux 1

3 packages built:
  • python37Packages.geopy
  • python38Packages.geopy
  • python39Packages.geopy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@GuillaumeDesforges GuillaumeDesforges Awaiting requested review from GuillaumeDesforges

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @SuperSandro2000 @GuillaumeDesforges