Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deshaw: create team and reassign limeytexan's maintainership #108678

Merged
merged 2 commits into from Jan 7, 2021
Merged

Deshaw: create team and reassign limeytexan's maintainership #108678

merged 2 commits into from Jan 7, 2021

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jan 7, 2021 •
edited

Motivation for this change

@limeytexan maintains these packages as part of their work at D. E. Shaw. Since the interested entity is deshaw, better to create a team of those people.

@limeytexan - can you reply with a 馃憤 on this PR?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@limeytexan
Copy link
Contributor

Thanks @grahamc for submitting! I can respond on behalf of @invokesus to confirm we both approve of the update. 馃憤

@grahamc
Copy link
Member Author

grahamc commented Jan 7, 2021

(force push, force push, force push ... I'll get it one day.)

lukegb
lukegb approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@grahamc grahamc merged commit b63aa4c into NixOS:master Jan 7, 2021
@grahamc grahamc deleted the deshaw-team branch January 7, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@stigtsp stigtsp Awaiting requested review from stigtsp stigtsp is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @limeytexan @lukegb