Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Allow to build dock on clearable watered object tiles #8514

Merged
merged 1 commit into from Nov 8, 2022
Merged

Change: Allow to build dock on clearable watered object tiles #8514

merged 1 commit into from Nov 8, 2022

Conversation

SamuXarick
Copy link
Contributor

Fix: Also add the cost of clearing objects on water

Motivation / Problem

NewGRF objects, like Rocks on water prever docks from being built.
Unnamed, 1950-01-01#6

But other water structures, such as buoys, ship depots, locks and aqueducks can be built on those Rocks.
Unnamed, 1950-01-01#4
Unnamed, 1950-01-01#5
Unnamed, 1950-01-01#7
Unnamed, 1950-01-01#8

Description

This PR allows docks to also be built on those Rocks.
Unnamed, 1950-01-01#9

Savegame:
place a dock here.zip

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@Eddi-z
Copy link
Contributor

Eddi-z commented Jan 7, 2021

Does this behavior have any precedence? like, what happens if you build a train station on land objects?

What is the fraction of players that rather not want to destroy objects? What happens on multi-tile objects?

@TrueBrain TrueBrain added candidate: needs considering This Pull Request needs more opinions size: small This Pull Request is small, and should be relative easy to process work: missing intention This Pull Request is missing "why" it exists labels Jan 7, 2021
@SamuXarick
Copy link
Contributor Author

Does this behavior have any precedence? like, what happens if you build a train station on land objects?

What is the fraction of players that rather not want to destroy objects? What happens on multi-tile objects?

I just tried building a rail station, road station, train depot, road vehicle depot, airport, road bridge, etc... they all clear the rock.
But then I tried to plant trees and it didn't allow it. Perhaps it should.

Interestingly, building a dock on a slope with rocky land, and a clear water tile for the pier, it is built.

@SamuXarick SamuXarick force-pushed the dock-allow-building-on-clearable-watered-object-tiles branch from 715b1ed to 676463e Compare June 6, 2021 15:09
@SamuXarick
Change: Allow to build dock on clearable watered object tiles
99b2420 
Fix: Also add the cost of clearing objects on water
@SamuXarick SamuXarick force-pushed the dock-allow-building-on-clearable-watered-object-tiles branch from 676463e to 99b2420 Compare June 12, 2022 15:14
2TallTyler
2TallTyler approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@2TallTyler 2TallTyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried building a rail station, road station, train depot, road vehicle depot, airport, road bridge, etc... they all clear the rock.
...
Interestingly, building a dock on a slope with rocky land, and a clear water tile for the pier, it is built.

To me, this PR would follow the precedent described here.

But then I tried to plant trees and it didn't allow it. Perhaps it should.

Out of scope for this PR of course, but I think trees should not destroy objects, since in my experience I often plant them in a big swatch over a town to boost rating. I wouldn't want them to destroy any objects which happened to be in the area. Placing docks is usually much more careful. 🙂

@2TallTyler 2TallTyler added this to the 13.0 milestone Oct 27, 2022
@2TallTyler 2TallTyler removed the work: missing intention This Pull Request is missing "why" it exists label Oct 28, 2022
@michicc michicc merged commit a8a7f95 into OpenTTD:master Nov 8, 2022
@SamuXarick SamuXarick deleted the dock-allow-building-on-clearable-watered-object-tiles branch December 5, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2TallTyler 2TallTyler 2TallTyler approved these changes

Assignees
No one assigned
Labels
candidate: needs considering This Pull Request needs more opinions size: small This Pull Request is small, and should be relative easy to process
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SamuXarick @Eddi-z @2TallTyler @michicc @TrueBrain