New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode-extensions.mikestead.dotenv: Add dotenv extension #108679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the commit message and title to vscode-extensions.mikestead.dotenv: Init at 1.0.1
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Oh jesus not again 😅 Okay I'll see what I can do - I've got a bunch of these I'd like to contribute (most with at least 1m downloads). What is the criteria for a valid commit message? No chance of squashing and setting a preferred message on merge? |
It is required for ofborg to work correctly.
It would be fine for me if they would be part of one big PR.
packageName: message
also see https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes |
@SuperSandro2000 thanks for the response! I'll get a PR in with all the packages. What do you want the name of the commit and the name of the PR to be (given there is more than one package involved)? |
Please do one commit per extensions and the name can be something like: |
Motivation for this change
Add dotenv extension
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)