Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.mikestead.dotenv: Add dotenv extension #108679

Closed
wants to merge 3 commits into from

Conversation

andyrichardson
Copy link
Contributor

@andyrichardson andyrichardson commented Jan 7, 2021

Motivation for this change

Add dotenv extension

Disclaimer: I won't be keeping this up to date as future releases are made.

It looks like there are already automation steps being made to keep extensions up to date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message and title to vscode-extensions.mikestead.dotenv: Init at 1.0.1

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@andyrichardson
Copy link
Contributor Author

Please change the commit message

Oh jesus not again 😅

Okay I'll see what I can do - I've got a bunch of these I'd like to contribute (most with at least 1m downloads).

What is the criteria for a valid commit message? No chance of squashing and setting a preferred message on merge?

@SuperSandro2000
Copy link
Member

Oh jesus not again 😅

It is required for ofborg to work correctly.

Okay I'll see what I can do - I've got a bunch of these I'd like to contribute (most with at least 1m downloads).

It would be fine for me if they would be part of one big PR.

What is the criteria for a valid commit message?

packageName: message

python3Packages.python-gitlab: Fixed X

also see https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

@andyrichardson
Copy link
Contributor Author

andyrichardson commented Jan 8, 2021

It would be fine for me if they would be part of one big PR.

@SuperSandro2000 thanks for the response! I'll get a PR in with all the packages.

What do you want the name of the commit and the name of the PR to be (given there is more than one package involved)?

@SuperSandro2000
Copy link
Member

What do you want the name of the commit and the name of the PR to be (given there is more than one package involved)?

Please do one commit per extensions and the name can be something like: vscode-extensions: Add X,Y,X and if this gets to long you can do vscode-extensions: Add several extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants