Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 13.7.1 -> 13.7.4 #108720

Merged
1 commit merged into from Jan 29, 2021
Merged

gitlab: 13.7.1 -> 13.7.4 #108720

1 commit merged into from Jan 29, 2021

Conversation

jslight90
Copy link
Contributor

@jslight90 jslight90 commented Jan 7, 2021 •
edited

Motivation for this change

Security fixes in GitLab.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jslight90
Copy link
Contributor Author

jslight90 commented Jan 7, 2021 •
edited

I tried running the NixOS tests, but I've been having problems lately with the QEMU VM timing out after about 45 minutes.

@ofborg ofborg bot requested review from globin, kalbasit, fpletz and talyz January 7, 2021 21:22
@jslight90 jslight90 changed the title gitlab: 13.7.1 -> 13.7.2 gitlab: 13.7.1 -> 13.7.3 Jan 8, 2021
@jslight90 jslight90 changed the title gitlab: 13.7.1 -> 13.7.3 gitlab: 13.7.1 -> 13.7.4 Jan 18, 2021
@ghost ghost merged commit e2c0897 into NixOS:master Jan 29, 2021
@ghost
Copy link

ghost commented Jan 29, 2021

Thanks! The NixOS test takes a while bit it eventually succeeds if you have a fast machine. I also did some extensive testing on a test instance.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@kalbasit kalbasit Awaiting requested review from kalbasit

@fpletz fpletz Awaiting requested review from fpletz

@talyz talyz Awaiting requested review from talyz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jslight90