Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't allow cloning vehicles if cloning orders is failing #8515

Merged
merged 1 commit into from Jan 7, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 7, 2021

Motivation / Problem

During investigation of #7972, I noticed that when you clone orders of a vehicle with invalid orders, you get notified, but if you clone the vehicle in a depot, the orders are not copied, without you being notified. I consider this evil, and so I fixed it.

Description

Before this fix, any failing clone order was silently ignored
and you as user would never know till you checked the order list.
Evil.

Selling the vehicle might seem like a strange solution, but if you look a few lines down, you see that this already happens. So it seems that is perfectly fine here :)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Before this fix, any failing clone order was silently ignored
and you as user would never know till you checked the order list.
Evil.
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@TrueBrain TrueBrain added this to the 1.11.0 milestone Jan 7, 2021
@TrueBrain TrueBrain merged commit 725d793 into OpenTTD:master Jan 7, 2021
@TrueBrain TrueBrain deleted the invalid-vehicle-orders branch January 7, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants