Fix: don't allow cloning vehicles if cloning orders is failing #8515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
During investigation of #7972, I noticed that when you clone orders of a vehicle with invalid orders, you get notified, but if you clone the vehicle in a depot, the orders are not copied, without you being notified. I consider this evil, and so I fixed it.
Description
Before this fix, any failing clone order was silently ignored
and you as user would never know till you checked the order list.
Evil.
Selling the vehicle might seem like a strange solution, but if you look a few lines down, you see that this already happens. So it seems that is perfectly fine here :)
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.