Add sh/bash dependency to fix 'missing sh in PATH' error #108668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
requested changes
Jan 8, 2021
There was a problem hiding this comment.
Please follow the "Submitting Changes" section of our CONTRIBUTING document, specifically the part regarding the formatting of commit messages.
The commit message should look something like sparkleshare: add bash to PATH.
(And also squash your commits into a single commit, please.)
kevincox
approved these changes
Jan 8, 2021
Sparkleshare requires 'sh' to be in its PATH, or push-operations fail. Its PATH consists of a single entry, which is configured in the postInstall phase. The bash-derivative includes 'sh', and adding it to the dependencies resolves the issue.
moritzschaefer
force-pushed
the
fix-sparkleshare-dependency
branch
from
00cee7e
to
b78ec60
Compare
|
Sorry for stealing your time, by not complyting to the CONTRIBUTING document @cole-h and @SuperSandro2000. I think it's all fixed now! |
|
No problem. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sparkleshare requires 'sh' to be in its PATH, or push-operations fail. Its PATH consists of a single entry, which is configured in the postInstall phase. The bash-derivative includes 'sh', and adding it to the dependencies resolves the issue.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)@kevincox