Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmltermwidget: fix build with gcc10 #108691

Merged
merged 1 commit into from Jan 7, 2021

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Jan 7, 2021

Motivation for this change

Fix the build for x86_64-linux which uses gcc10.

https://hydra.nixos.org/eval/1640445?filter=qmltermwidget&compare=1640366&full=

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108691 run on x86_64-linux 1

4 packages built:
  • cool-retro-term
  • libsForQt5.qmltermwidget (libsForQt515.qmltermwidget)
  • libsForQt512.qmltermwidget
  • libsForQt514.qmltermwidget

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108691 run on x86_64-darwin 1

4 packages built:
  • cool-retro-term
  • libsForQt5.qmltermwidget (libsForQt512.qmltermwidget)
  • libsForQt514.qmltermwidget
  • libsForQt515.qmltermwidget

@SuperSandro2000 SuperSandro2000 merged commit 1412194 into NixOS:master Jan 7, 2021
@B4dM4n B4dM4n deleted the qmltermwidget-fix branch January 7, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants