Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls: set RUST_SRC_PATH to rustLibSrc #108652

Merged
merged 1 commit into from Jan 7, 2021
Merged

rls: set RUST_SRC_PATH to rustLibSrc #108652

merged 1 commit into from Jan 7, 2021

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Jan 7, 2021

Motivation for this change

rls uses racer for completion, based what I saw in 61b8a2c RUST_SRC_PATH should be set to rustPlatform.rustLibSrc

cc @Ma27

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jan 7, 2021

LGTM based on what I've seen in rust-analyzer as well.

@Ma27 Ma27 merged commit 2020d15 into NixOS:master Jan 7, 2021
@lblasc lblasc deleted the rls-rust-src branch January 7, 2021 11:17
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108652 run on x86_64-linux 1

1 package built:
  • rls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants