Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3: don't use sysconfigdataHook on darwin #108670

Merged
merged 1 commit into from Jan 8, 2021
Merged

python3: don't use sysconfigdataHook on darwin #108670

merged 1 commit into from Jan 8, 2021

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 7, 2021

Resolves issue when building wheels which is a regression introduced by
1a65c5d

AssertionError: would build wheel with unsupported tag ('cp38', 'cp38',
'darwin_x86_64')
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
python3: don't use sysconfigdataHook on darwin
a637e1e 
Resolves issue when building wheels which is a regression introduced by
1a65c5d

```
AssertionError: would build wheel with unsupported tag ('cp38', 'cp38',
'darwin_x86_64')
```
@FRidh FRidh requested a review from lopsided98 January 7, 2021 13:39
@FRidh
Copy link
Member Author

FRidh commented Jan 7, 2021

@GrahamcOfBorg build python3.pkgs.pip-tools

@FRidh FRidh mentioned this pull request Jan 7, 2021
Merged
10 tasks
@FRidh
Copy link
Member Author

FRidh commented Jan 7, 2021

@r-burns could you test building python3.pkgs.pip-tools or python3.pkgs.cython?

@r-burns
Copy link
Contributor

r-burns commented Jan 7, 2021

On it.

@lopsided98
Copy link
Contributor

It seems like there should be another way to fix this, but I have no access to a Darwin machine so I can't look into it much, so I guess this is fine.

r-burns
r-burns approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built python3.pkgs.cython and python3.pkgs.markupsafe

@FRidh FRidh merged commit 5c8df22 into NixOS:staging-next Jan 8, 2021
@FRidh
Copy link
Member Author

FRidh commented Jan 8, 2021

Thanks @r-burns !

@FRidh FRidh deleted the sysconfig branch January 8, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns approved these changes

@lopsided98 lopsided98 Awaiting requested review from lopsided98

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @r-burns @lopsided98