New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux_zen: 5.10.1 -> 5.10.5 #108688
linux_zen: 5.10.1 -> 5.10.5 #108688
Conversation
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
/status needs_merger |
Have you verified that the packages that failed to build in the |
They all sound like modules that also fail on vanilla 5.10 and many failed on 5.9 too. |
I compared the lists and these modules are not in the list of current
Could you double-check if they built before the update? |
Those are proprietary modules and that's why they don't show up in the hydra build failures, it doesn't even attempt to build them. amdgpu-pro is only compatible with one kernel version, the legacy nvidia drivers are even less compatible than their newest shiny BLOB of crap and the other two I wouldn't expect to be compatible with any reasonably up-to-date kernel. A quick check confirmed that just now. Broken modules are simple not being marked as such when a new ABI-incompatible kernel version is added to Nixpkgs. We didn't even have the infrastructure to support doing that until very recently and I'm not sure whether that has been forward-ported from 20.09 yet. Most of these have been broken for as long as the zen kernel has been in Nixpkgs, that's why I didn't even bother investigating these "failures". The zen kernel is also fairly vanilla and, if anything, it'd support more modules than the mainline kernel. |
@timokau All 5 of those fail to build on 5.10.1 for me:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM. I ran nixpkgs-review
on the bump to 5.10.1 as well, and all the same packages are broken / failed to build (except hyperv-daemons
was fixed, it looks like).
Result of nixpkgs-review pr 108688
run on x86_64-linux 1
8 packages marked as broken and skipped:
- linuxPackages_zen.ixgbevf
- linuxPackages_zen.lttng-modules
- linuxPackages_zen.ndiswrapper
- linuxPackages_zen.nvidia_x11_legacy304
- linuxPackages_zen.phc-intel
- linuxPackages_zen.rtl8723bs
- linuxPackages_zen.sch_cake
- linuxPackages_zen.tbs
22 packages failed to build:
- linuxPackages_zen.akvcam
- linuxPackages_zen.amdgpu-pro
- linuxPackages_zen.anbox
- linuxPackages_zen.chipsec
- linuxPackages_zen.cryptodev
- linuxPackages_zen.dpdk
- linuxPackages_zen.ena
- linuxPackages_zen.mwprocapture
- linuxPackages_zen.mxu11x0
- linuxPackages_zen.nvidia_x11_legacy340
- linuxPackages_zen.nvidia_x11_legacy390
- linuxPackages_zen.oci-seccomp-bpf-hook
- linuxPackages_zen.rtl8192eu
- linuxPackages_zen.rtl8812au
- linuxPackages_zen.rtl8814au
- linuxPackages_zen.rtl8821au
- linuxPackages_zen.rtl8821ce
- linuxPackages_zen.rtl88x2bu
- linuxPackages_zen.rtl88xxau-aircrack
- linuxPackages_zen.rtlwifi_new
- linuxPackages_zen.virtualbox
- linuxPackages_zen.virtualboxGuestAdditions
51 packages built:
- linuxPackages_zen.acpi_call
- linuxPackages_zen.asus-wmi-sensors
- linuxPackages_zen.batman_adv
- linuxPackages_zen.bbswitch
- linuxPackages_zen.bcc
- linuxPackages_zen.bpftrace
- linuxPackages_zen.broadcom_sta
- linuxPackages_zen.can-isotp
- linuxPackages_zen.cpupower
- linuxPackages_zen.ddcci-driver
- linuxPackages_zen.digimend
- linuxPackages_zen.evdi
- linuxPackages_zen.facetimehd
- linuxPackages_zen.fwts-efi-runtime
- linuxPackages_zen.gcadapter-oc-kmod
- linuxPackages_zen.hyperv-daemons
- linuxPackages_zen.intel-speed-select
- linuxPackages_zen.it87
- linuxPackages_zen.jool
- linux_zen (linuxPackages_zen.kernel)
- linuxPackages_zen.mba6x_bl
- linuxPackages_zen.netatop
- linuxPackages_zen.nvidia_x11
- linuxPackages_zen.nvidia_x11_beta
- linuxPackages_zen.nvidia_x11_vulkan_beta
- linuxPackages_zen.nvidiabl
- linuxPackages_zen.openafs (linuxPackages_zen.openafs_1_8)
- linuxPackages_zen.openafs_1_9
- linuxPackages_zen.openrazer
- linuxPackages_zen.perf
- linuxPackages_zen.ply
- linuxPackages_zen.r8125
- linuxPackages_zen.r8168
- linuxPackages_zen.rtl8821cu
- linuxPackages_zen.sysdig
- linuxPackages_zen.system76
- linuxPackages_zen.system76-acpi
- linuxPackages_zen.system76-io
- linuxPackages_zen.systemtap
- linuxPackages_zen.tmon
- linuxPackages_zen.tp_smapi
- linuxPackages_zen.turbostat
- linuxPackages_zen.tuxedo-keyboard
- linuxPackages_zen.usbip
- linuxPackages_zen.v4l2loopback
- linuxPackages_zen.v86d
- linuxPackages_zen.vhba
- linuxPackages_zen.x86_energy_perf_policy
- linuxPackages_zen.xpadneo
- linuxPackages_zen.zenpower
- linuxPackages_zen.zfs (linuxPackages_zen.zfsStable ,linuxPackages_zen.zfsUnstable)
I see that this has already been resolved in #108958. Thank you for the explanations and for keeping the package up to date. It would be nice to mark those modules as broken for incompatible kernel versions, but I agree that is out of scope for this PR. |
Motivation for this change
Closes #108239
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)/marvin opt-in
/status needs_reviewer
Result of
nixpkgs-review
run on x86_64-linux 18 packages marked as broken and skipped:
23 packages failed to build:
51 packages built: