Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.unite-shell: init at 44 #108714

Merged
merged 2 commits into from Jan 12, 2021
Merged

gnomeExtensions.unite-shell: init at 44 #108714

merged 2 commits into from Jan 12, 2021

Conversation

rhoriguchi
Copy link
Contributor

Motivation for this change

Add support for GNOME unite-shell

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 7, 2021
@rhoriguchi rhoriguchi closed this Jan 7, 2021
@rhoriguchi rhoriguchi reopened this Jan 7, 2021
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108714 run on x86_64-linux 1

1 package marked as broken and skipped:
  • gnomeExtensions.unite-shell

SuperSandro2000
SuperSandro2000 requested changes Jan 10, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the 0.1.6 file.

pkgs/desktops/gnome-3/extensions/unite-shell/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/gnome-3/extensions/unite-shell/default.nix Outdated Show resolved Hide resolved
@rhoriguchi
Copy link
Contributor Author

Sorry for the sloppiness and thank you for the reviews.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108714 run on x86_64-linux 1

1 package marked as broken and skipped:
  • gnomeExtensions.unite-shell

@SuperSandro2000
Copy link
Member

error: Package ‘gnome-shell-extension-unite-shell-44’ in /home/hotpi/src/nixpkgs2/pkgs/desktops/gnome-3/extensions/unite-shell/default.nix:33 is marked as broken, refusing to evaluate.

@rhoriguchi
Copy link
Contributor Author

rhoriguchi commented Jan 11, 2021 •
edited

error: Package ‘gnome-shell-extension-unite-shell-44’ in /home/hotpi/src/nixpkgs2/pkgs/desktops/gnome-3/extensions/unite-shell/default.nix:33 is marked as broken, refusing to evaluate.

I finally understand why it's broken I was so confused because it worked in my derivation where I ignored the error with nixpkgs.config.allowBroken = true because I assumed it's because of the pr. The issue is, that I interpreted versionAtLeast wrongly, what I wanted was versionOlder.

It should work now:

> nixpkgs-review pr 108714

1 package built:
gnomeExtensions.unite-shell

Thank you for the help.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108714 run on x86_64-linux 1

1 package built:
  • gnomeExtensions.unite-shell

@SuperSandro2000 SuperSandro2000 merged commit 805821e into NixOS:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rhoriguchi @SuperSandro2000 @sikmir