Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert chardet to 3.0.4 to fix compatibility issue with aiohttp, … #79

Closed
wants to merge 2 commits into from
Closed

Revert chardet to 3.0.4 to fix compatibility issue with aiohttp, … #79

wants to merge 2 commits into from

Conversation

erenes
Copy link
Contributor

@erenes erenes commented Jan 7, 2021

…and also added other packages that caused the diff step in the docker build to fail.

I have verified the docker build works, but hope the github actions will take care of the other checks.

…and also added other packages that caused the diff step in the docker build to fail
@erenes erenes changed the title downgraded chardet to 3.0.4 to fix compatibility issue with aiohttp, … Revert chardet to 3.0.4 to fix compatibility issue with aiohttp, … Jan 7, 2021
@TrueBrain
Copy link
Member

Thank you for this <3

This was bound to happen with some package, with the new pip being a lot more strict about the dependencies. Upstream aiohttp already fixed this, but it requires a new release from them. Not sure when that will happen.

I will process this a bit later this week; been slacking with accepting the pyup patches it seems :D

@TrueBrain TrueBrain closed this Feb 1, 2021
@TrueBrain TrueBrain deleted the branch OpenTTD:pyup-scheduled-update-2021-01-01 February 1, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants