Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libplacebo: fixup glslang headers path #108727

Merged
merged 1 commit into from Jan 7, 2021
Merged

libplacebo: fixup glslang headers path #108727

merged 1 commit into from Jan 7, 2021

Conversation

baloo
Copy link
Member

@baloo baloo commented Jan 7, 2021

Motivation for this change

See: #108723

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@baloo
libplacebo: fixup glslang headers path
f44ed8a 
See: NixOS#108723

Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
primeos
primeos approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) Much appreciated!

@primeos primeos linked an issue Jan 7, 2021 that may be closed by this pull request
libplacebo-2.72.2 fails to build due to glslang / path issue #108723
Closed
@primeos primeos merged commit e597a82 into NixOS:master Jan 7, 2021
@baloo
Copy link
Member Author

baloo commented Jan 7, 2021 •
edited

(@primeos If you have an account on code.videolan.org to upstream the patch :D that'd be appreciated)

@baloo baloo deleted the baloo/libplacebo/glsl-import branch January 7, 2021 22:33
@primeos
Copy link
Member

primeos commented Jan 7, 2021

@baloo not yet :o Feel free to submit it if you want, if not I can take care of it tomorrow.

@ofborg ofborg bot requested review from primeos and tadeokondrak January 7, 2021 22:38
@baloo baloo restored the baloo/libplacebo/glsl-import branch January 7, 2021 22:48
@baloo
Copy link
Member Author

baloo commented Jan 7, 2021

https://code.videolan.org/videolan/libplacebo/-/merge_requests/131

@baloo baloo mentioned this pull request Jan 7, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos Awaiting requested review from primeos

@tadeokondrak tadeokondrak Awaiting requested review from tadeokondrak

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libplacebo-2.72.2 fails to build due to glslang / path issue
2 participants
@baloo @primeos