Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtk: use system png on aarch #108748

Merged
merged 1 commit into from Jan 8, 2021
Merged

vtk: use system png on aarch #108748

merged 1 commit into from Jan 8, 2021

Conversation

3noch
Copy link
Contributor

@3noch 3noch commented Jan 8, 2021 •
edited

Motivation for this change

For some reason VTK doesn't produce png symbols on aarch64. It looks like vtk is just embedding libpng anyway so we can just use the same trick we're already using for TIFF and tell vtk to use our libpng. This minimizes the number of places we have to maintain Nixpkgs compat.

Things done

Tested linking against png symbols on aarch64.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@3noch
vtk: use system png
26dedb8 
VTK doesn't seem produce png symbols on aarch64. We could probably
figure out how to fix that but we can also just tell it to use the
libpng we already have, which already works on aarch64.
@lheckemann lheckemann merged commit c7e546a into NixOS:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@tfmoraes tfmoraes Awaiting requested review from tfmoraes

@lheckemann lheckemann Awaiting requested review from lheckemann

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@3noch @SuperSandro2000 @lheckemann