Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Remove min/max functions in favour of STL variants #8502

Merged
merged 1 commit into from Jan 8, 2021

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Jan 5, 2021

Motivation / Problem

Scratching an itch.

Description

Largely mechanical adding of std::
Also removed several (now unnecessary) casts in the process
And added some necessary ones to make the type explicit (where they otherwise differed)
And made a static const member variable constexpr, to make compilers happy

Limitations

Might be some unintentional integer truncation due to types changing. (e.g. uint64 foo = std::max(UINT16_MAX, bigger_int); )

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro force-pushed the remove-minmax branch 2 times, most recently from 80d16c1 to 3950a68 Compare January 7, 2021 21:09
frosch123
frosch123 previously approved these changes Jan 7, 2021
TrueBrain
TrueBrain previously approved these changes Jan 7, 2021
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

181 files .. yeah sure, what-ever.

@glx22
Copy link
Contributor

glx22 commented Jan 8, 2021

Ok windows checks passed without warnings, except commit checker, but that was intended so you can review my changes before fixup.
#8522 added many gcc/clang warnings

@TrueBrain TrueBrain merged commit 9b800a9 into OpenTTD:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants