Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09]: php 7.3.24 -> 7.3.26, 7.4.12 -> 7.4.14 #108737

Merged
merged 5 commits into from Jan 17, 2021
Merged

[20.09]: php 7.3.24 -> 7.3.26, 7.4.12 -> 7.4.14 #108737

merged 5 commits into from Jan 17, 2021

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 8, 2021

Motivation for this change

cc @NixOS/php

Backport of #102818, #105040 and #108666

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Ma27, etu, aanderse, globin and talyz January 8, 2021 00:50
@ajs124 ajs124 marked this pull request as ready for review January 9, 2021 17:02
@ajs124
Copy link
Member Author

ajs124 commented Jan 16, 2021

@NixOS/php could someone review this? I'd really rather not self-merge, even though this is just a backport, especially since it also splits the realses out to ease backporting.

@etu etu merged commit f5f6614 into NixOS:release-20.09 Jan 17, 2021
@ajs124 ajs124 deleted the backport/20.09/php branch January 17, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@etu etu Awaiting requested review from etu

@aanderse aanderse Awaiting requested review from aanderse

@globin globin Awaiting requested review from globin

@talyz talyz Awaiting requested review from talyz

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @etu