-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
ajour: init at 0.6.3 #108738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ajour: init at 0.6.3 #108738
Conversation
This comment has been minimized.
This comment has been minimized.
Thanks, marked as draft, and your post as off-topic, as you said yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mweinelt! I don't actually play WoW (even though I still have it installed 😛), but I can still help review this.
Would the game directory selection normally open a GTK / Qt file dialog? You might need to specify some of the environment variables that are normally set in wrapGAppsHook
or wrapQtAppsHook
.
@mweinelt It looks like |
5ba1531
to
d5c88e8
Compare
Yeah, that was it. I went ahead and put zenity and kdialog in the PATH and it is working now. |
Result of 1 package built:
|
When I run the package on Arch Linux, it simply does nothing and exits with code 101 right away :( The strace line |
@piegamesde Do you know if this panic is caused by a missing runtime library? You can check with |
So, apparently exit code 101 is the panic exit code. So if this is not an abort, why am I not seeing a backtrace? I don't know how |
@piegamesde It looks like ajour uses log-panics to capture panic messages to a log file. Looking through the source, it seems like it should be writing them to |
@Metadark Thanks. That explains why the strace command showed the application writing to FD 3 instead of 2 … yeah, there's definitely something of interest in there:
|
Funny, that's basically how I started out, before I started patching the RPATH. Can you test the latest change? It adds all the libraries that I set the RPATH for to buildInputs. |
Nope, no change :/ maybe I should open a bug upstream asking for better log diagnostics … |
@piegamesde Can you strace the process and check if it is unable to open any libraries? |
Result of 1 package marked as broken and skipped:
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
Result of 1 package built:
|
Something is really weird.
I renamed this from
I've just rebased this onto master and it still builds for me with just |
The kdeApplications problem was introduced by #102168 |
Migrated to |
Motivation for this change
A cross-plattform addon manager for World of Warcraft.
https://github.com/casperstorm/ajour
cc @Metadark @cawilliamson
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)