New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.09] picom: 8 -> 8.2, backport fixes #108744
Conversation
(cherry picked from commit c25930e)
(cherry picked from commit 4fcf71f)
- Build option `build_docs` was renamed to `with_docs` quite sometime ago: yshui/picom@3f2a671. This means that the manpage were not being build. - Remove CFLAG `-fno-strict-aliasing` seems to not be used anywhere in the upstream repository. This was probably added for `compton` a long time ago and never removed, since I can't find the commit that added this. - Use release build. This is recommended upstream: https://github.com/yshui/picom#to-build. (cherry picked from commit 67e2cb0)
Result of 1 package built:
|
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Reminder: Please review! This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually. |
/status needs_reviewer |
Reminder: Please review! This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually. |
1 similar comment
Reminder: Please review! This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually. |
Motivation for this change
The main reason is because of the manpage fixes, but since I am already backporting I decided to get the newer minor version release too that should fix some crashes.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)