Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] picom: 8 -> 8.2, backport fixes #108744

Closed
wants to merge 3 commits into from
Closed

[20.09] picom: 8 -> 8.2, backport fixes #108744

wants to merge 3 commits into from

Conversation

thiagokokada
Copy link
Contributor

Motivation for this change

The main reason is because of the manpage fixes, but since I am already backporting I decided to get the newer minor version release too that should fix some crashes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

(cherry picked from commit c25930e)
(cherry picked from commit 4fcf71f)
- Build option `build_docs` was renamed to `with_docs` quite sometime ago:
  yshui/picom@3f2a671.
  This means that the manpage were not being build.
- Remove CFLAG `-fno-strict-aliasing` seems to not be used anywhere in the
  upstream repository. This was probably added for `compton` a long time
  ago and never removed, since I can't find the commit that added this.
- Use release build. This is recommended upstream:
  https://github.com/yshui/picom#to-build.

(cherry picked from commit 67e2cb0)
@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 108744 1

1 package built:
  • picom (compton)

@thiagokokada
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 8, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/437

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 12, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.


Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

@thiagokokada
Copy link
Contributor Author

/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 19, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.


Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

1 similar comment
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 23, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.


Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

@thiagokokada thiagokokada deleted the backport-picom branch January 24, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants