Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bibtex2html: add perl dependency #108704

Merged
merged 1 commit into from Jan 7, 2021
Merged

bibtex2html: add perl dependency #108704

merged 1 commit into from Jan 7, 2021

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Jan 7, 2021

The aux2bib tool that is part of the bibtex2html package requires
perl. Without this dependency, the aux2bib script is installed with
a shebang pointing to /usr/bin/perl.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@acowley
bibtex2html: add perl dependency
d620de4 
The `aux2bib` tool that is part of the bibtex2html package requires
perl. Without this dependency, the `aux2bib` script is installed with
a shebang pointing to `/usr/bin/perl`.
@ofborg ofborg bot requested a review from scolobb January 7, 2021 18:31
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108704 run on x86_64-linux 1

1 package built:
  • bibtex2html

@hugolgst
Copy link
Member

hugolgst commented Jan 7, 2021

Result of nixpkgs-review pr 108704 1

1 package built:
  • bibtex2html

@SuperSandro2000 SuperSandro2000 merged commit 610ec6f into NixOS:master Jan 7, 2021
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108704 run on x86_64-darwin 1

1 package built:
  • bibtex2html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scolobb scolobb scolobb approved these changes

@hugolgst hugolgst hugolgst approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 needs_merger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acowley @SuperSandro2000 @hugolgst @scolobb