Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow: fix build #108696

Merged
merged 2 commits into from Jan 7, 2021
Merged

tensorflow: fix build #108696

merged 2 commits into from Jan 7, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 7, 2021

Motivation for this change

With gcc 10, tensorflow 2 broke. Also remove tensorflow 1 which does no longer work with our current default python3 version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title tensorflow: drop 1.x tensorflow: fix build Jan 7, 2021
pkgs/top-level/python-packages.nix Show resolved Hide resolved
pkgs/top-level/python-packages.nix Show resolved Hide resolved
pkgs/top-level/python-packages.nix Show resolved Hide resolved
pkgs/top-level/python-packages.nix Show resolved Hide resolved
it no longer works without our default python version and needs
many patches to compile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants