Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorio-experimental, factorio-headless-experimental: 1.1.7 -> 1.1.8 #108736

Merged
merged 1 commit into from Jan 8, 2021

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Jan 8, 2021

Motivation for this change

https://forums.factorio.com/94034

๐Ÿš‚๐Ÿ—บ๏ธ

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
Copy link
Contributor Author

lukegb commented Jan 8, 2021

Two PRs for updating Factorio in one day.

sigh

:P

@SuperSandro2000
Copy link
Member

Two PRs for updating Factorio in one day.

sigh

:P

Like in the good old 0.17.X days.

Copy link
Contributor

@priegger priegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I tested on x86_64 NixOS, the factorio service running on a remote machine and my local machine connecting to it. 1.1.8 on both sides. No issues so far.

Thanks!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108736 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • factorio-experimental: log was empty
1 package built:
  • factorio-headless-experimental

@SuperSandro2000 SuperSandro2000 merged commit 8459558 into NixOS:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants