Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy: init at 1.16.2 #108741

Merged
merged 2 commits into from Jan 19, 2021
Merged

envoy: init at 1.16.2 #108741

merged 2 commits into from Jan 19, 2021

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Jan 8, 2021

Motivation for this change

Add Envoy, a cloud-native proxy.

I'm adding this because I want to add Pomerium, and Envoy is a dependency (it's the data-plane proxy that Pomerium uses).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb lukegb mentioned this pull request Jan 8, 2021
Merged
10 tasks
@lukegb lukegb marked this pull request as draft January 8, 2021 03:06
@lukegb
Copy link
Contributor Author

lukegb commented Jan 8, 2021

@ofborg build envoy

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108741 run on x86_64-darwin 1

13 packages marked as broken and skipped:
  • bazel-watcher
  • python37Packages.baselines
  • python37Packages.graph_nets
  • python37Packages.mask-rcnn
  • python37Packages.optuna
  • python37Packages.rl-coach
  • python38Packages.baselines
  • python38Packages.graph_nets
  • python38Packages.mask-rcnn
  • python38Packages.optuna
  • python38Packages.rl-coach
  • python39Packages.baselines
  • python39Packages.graph_nets
29 packages failed to build and are new build failures:
  • bazel-remote: log https://termbin.com/kzun
  • python37Packages.arviz: log was empty
  • python37Packages.edward: log was empty
  • python37Packages.pymc3: log was empty
  • python37Packages.tensorflow: log was empty
  • (python37Packages.tensorflow-build: log was empty
  • ,python37Packages.tensorflow-build_2: log was empty
  • ,python37Packages.tensorflowWithoutCuda: log was empty
  • ,python37Packages.tensorflow_2): log was empty
  • python37Packages.tensorflow-probability: log was empty
  • python37Packages.tflearn: log was empty
  • python38Packages.arviz: log was empty
  • python38Packages.edward: log was empty
  • python38Packages.pymc3: log was empty
  • python38Packages.tensorflow: log was empty
  • (python38Packages.tensorflow-build: log was empty
  • ,python38Packages.tensorflow-build_2: log was empty
  • ,python38Packages.tensorflowWithoutCuda: log was empty
  • ,python38Packages.tensorflow_2): log was empty
  • python38Packages.tensorflow-probability: log was empty
  • python38Packages.tflearn: log was empty
  • python39Packages.edward: log was empty
  • python39Packages.tensorflow: log was empty
  • (python39Packages.tensorflow-build: log was empty
  • ,python39Packages.tensorflow-build_2: log was empty
  • ,python39Packages.tensorflowWithoutCuda: log was empty
  • ,python39Packages.tensorflow_2): log was empty
  • python39Packages.tensorflow-probability: log was empty
  • python39Packages.tflearn: log was empty

@lukegb
Copy link
Contributor Author

lukegb commented Jan 9, 2021

@ofborg build envoy

@lukegb
Copy link
Contributor Author

lukegb commented Jan 9, 2021

@ofborg build envoy

@lukegb lukegb marked this pull request as ready for review January 9, 2021 00:47
@lukegb
Copy link
Contributor Author

lukegb commented Jan 9, 2021

@ofborg eval

@lukegb
Copy link
Contributor Author

lukegb commented Jan 9, 2021

Result of nixpkgs-review pr 108741 run on x86_64-darwin 1

13 packages marked as broken and skipped:
  • bazel-watcher
  • python37Packages.baselines
  • python37Packages.graph_nets
  • python37Packages.mask-rcnn
  • python37Packages.optuna
  • python37Packages.rl-coach
  • python38Packages.baselines
  • python38Packages.graph_nets
  • python38Packages.mask-rcnn
  • python38Packages.optuna
  • python38Packages.rl-coach
  • python39Packages.baselines
  • python39Packages.graph_nets
18 packages failed to build:
  • bazel-remote
  • python37Packages.arviz
  • python37Packages.edward
  • python37Packages.pymc3
  • python37Packages.tensorflow (python37Packages.tensorflow-build ,python37Packages.tensorflow-build_2 ,python37Packages.tensorflowWithoutCuda ,python37Packages.tensorflow_2)
  • python37Packages.tensorflow-probability
  • python37Packages.tflearn
  • python38Packages.arviz
  • python38Packages.edward
  • python38Packages.pymc3
  • python38Packages.tensorflow (python38Packages.tensorflow-build ,python38Packages.tensorflow-build_2 ,python38Packages.tensorflowWithoutCuda ,python38Packages.tensorflow_2)
  • python38Packages.tensorflow-probability
  • python38Packages.tflearn
  • python39Packages.edward
  • python39Packages.tensorflow (python39Packages.tensorflow-build ,python39Packages.tensorflow-build_2 ,python39Packages.tensorflowWithoutCuda ,python39Packages.tensorflow_2)
  • python39Packages.tensorflow-probability
  • python39Packages.tflearn
  • tts

@lukegb
Copy link
Contributor Author

lukegb commented Jan 9, 2021

Result of nixpkgs-review pr 108741 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python37Packages.rl-coach
  • python38Packages.rl-coach
28 packages failed to build:
  • python37Packages.arviz
  • python37Packages.baselines
  • python37Packages.dm-sonnet
  • python37Packages.edward
  • python37Packages.graph_nets
  • python37Packages.mask-rcnn
  • python37Packages.optuna
  • python37Packages.pymc3
  • python37Packages.tensorflow (python37Packages.tensorflow-build ,python37Packages.tensorflow-build_2 ,python37Packages.tensorflowWithoutCuda ,python37Packages.tensorflow_2)
  • python37Packages.tensorflow-probability
  • python37Packages.tensorflowWithCuda
  • python37Packages.tflearn
  • python38Packages.arviz
  • python38Packages.baselines
  • python38Packages.dm-sonnet
  • python38Packages.edward
  • python38Packages.graph_nets
  • python38Packages.mask-rcnn
  • python38Packages.optuna
  • python38Packages.pymc3
  • python38Packages.tensorflow (python38Packages.tensorflow-build ,python38Packages.tensorflow-build_2 ,python38Packages.tensorflowWithoutCuda ,python38Packages.tensorflow_2)
  • python38Packages.tensorflow-probability
  • python38Packages.tflearn
  • python39Packages.dm-sonnet
  • python39Packages.graph_nets
  • python39Packages.tensorflow-probability
  • python39Packages.tensorflowWithCuda
  • tts
9 packages built:
  • bazel-remote
  • bazel-watcher
  • envoy
  • gvisor
  • python38Packages.tensorflowWithCuda
  • python39Packages.baselines
  • python39Packages.edward
  • python39Packages.tensorflow (python39Packages.tensorflow-build ,python39Packages.tensorflow-build_2 ,python39Packages.tensorflowWithoutCuda ,python39Packages.tensorflow_2)
  • python39Packages.tflearn

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108741 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python37Packages.rl-coach
  • python38Packages.rl-coach
45 packages failed to build and are new build failures:
  • envoy: log was empty
  • python37Packages.arviz: log was empty
  • python37Packages.baselines: log was empty
  • python37Packages.dm-sonnet: log was empty
  • python37Packages.edward: log was empty
  • python37Packages.graph_nets: log was empty
  • python37Packages.mask-rcnn: log was empty
  • python37Packages.optuna: log was empty
  • python37Packages.pymc3: log was empty
  • python37Packages.tensorflow: log was empty
  • (python37Packages.tensorflow-build: log was empty
  • ,python37Packages.tensorflow-build_2: log was empty
  • ,python37Packages.tensorflowWithoutCuda: log was empty
  • ,python37Packages.tensorflow_2): log was empty
  • python37Packages.tensorflow-probability: log was empty
  • python37Packages.tensorflowWithCuda: log was empty
  • python37Packages.tflearn: log was empty
  • python38Packages.arviz: log was empty
  • python38Packages.baselines: log was empty
  • python38Packages.dm-sonnet: log was empty
  • python38Packages.edward: log was empty
  • python38Packages.graph_nets: log was empty
  • python38Packages.mask-rcnn: log was empty
  • python38Packages.optuna: log was empty
  • python38Packages.pymc3: log was empty
  • python38Packages.tensorflow: log was empty
  • (python38Packages.tensorflow-build: log was empty
  • ,python38Packages.tensorflow-build_2: log was empty
  • ,python38Packages.tensorflowWithoutCuda: log was empty
  • ,python38Packages.tensorflow_2): log was empty
  • python38Packages.tensorflow-probability: log was empty
  • python38Packages.tensorflowWithCuda: log was empty
  • python38Packages.tflearn: log was empty
  • python39Packages.baselines: log was empty
  • python39Packages.dm-sonnet: log was empty
  • python39Packages.edward: log was empty
  • python39Packages.graph_nets: log was empty
  • python39Packages.tensorflow: log was empty
  • (python39Packages.tensorflow-build: log was empty
  • ,python39Packages.tensorflow-build_2: log was empty
  • ,python39Packages.tensorflowWithoutCuda: log was empty
  • ,python39Packages.tensorflow_2): log was empty
  • python39Packages.tensorflow-probability: log was empty
  • python39Packages.tensorflowWithCuda: log was empty
  • python39Packages.tflearn: log was empty
3 packages built:
  • bazel-remote
  • bazel-watcher
  • gvisor

@lukegb
Copy link
Contributor Author

lukegb commented Jan 9, 2021

Result of nixpkgs-review pr 108741 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python37Packages.rl-coach
  • python38Packages.rl-coach
28 packages failed to build:
  • python37Packages.arviz
  • python37Packages.baselines
  • python37Packages.dm-sonnet
  • python37Packages.edward
  • python37Packages.graph_nets
  • python37Packages.mask-rcnn
  • python37Packages.optuna
  • python37Packages.pymc3
  • python37Packages.tensorflow (python37Packages.tensorflow-build ,python37Packages.tensorflow-build_2 ,python37Packages.tensorflowWithoutCuda ,python37Packages.tensorflow_2)
  • python37Packages.tensorflow-probability
  • python37Packages.tensorflowWithCuda
  • python37Packages.tflearn
  • python38Packages.arviz
  • python38Packages.baselines
  • python38Packages.dm-sonnet
  • python38Packages.edward
  • python38Packages.graph_nets
  • python38Packages.mask-rcnn
  • python38Packages.optuna
  • python38Packages.pymc3
  • python38Packages.tensorflow (python38Packages.tensorflow-build ,python38Packages.tensorflow-build_2 ,python38Packages.tensorflowWithoutCuda ,python38Packages.tensorflow_2)
  • python38Packages.tensorflow-probability
  • python38Packages.tflearn
  • python39Packages.dm-sonnet
  • python39Packages.graph_nets
  • python39Packages.tensorflow-probability
  • python39Packages.tensorflowWithCuda
  • tts
9 packages built:
  • bazel-remote
  • bazel-watcher
  • envoy
  • gvisor
  • python38Packages.tensorflowWithCuda
  • python39Packages.baselines
  • python39Packages.edward
  • python39Packages.tensorflow (python39Packages.tensorflow-build ,python39Packages.tensorflow-build_2 ,python39Packages.tensorflowWithoutCuda ,python39Packages.tensorflow_2)
  • python39Packages.tflearn

@lukegb lukegb mentioned this pull request Jan 10, 2021
Merged
10 tasks
@lukegb lukegb marked this pull request as draft January 13, 2021 00:13
@lukegb lukegb marked this pull request as ready for review January 13, 2021 02:16
@SuperSandro2000
Copy link
Member 

hash mismatch in fixed-output derivation '/nix/store/cgxm8fc7fyx20n0f8j6jbjiibmyzs7nk-envoy-1.16.2-deps.tar.gz':
  wanted: sha256:0k2npf8f68iladnrai8jnfqc76440lpvc5sw1qv8bjpcrg97i4n7
  got:    sha256:1ycxrgj8nzv9j4x6g1clgg99id6hbq0399jkz1bs0673v60mjf95
cannot build derivation '/nix/store/y0yp6lmhqqbi5bkmqxc7v6rqf6sg0j80-envoy-1.16.2.drv': 1 dependencies couldn't be built

@lukegb
Copy link
Contributor Author

lukegb commented Jan 13, 2021

@ofborg build envoy

@lukegb
Copy link
Contributor Author

lukegb commented Jan 14, 2021

Hooray. I have now managed to remove all the outstanding references into the nix store from the envoy.deps build, which should avoid the hash changing as dependency versions are bumped.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108741 run on x86_64-darwin 1

27 packages marked as broken and skipped:
  • bazel-watcher
  • python37Packages.arviz
  • python37Packages.baselines
  • python37Packages.graph_nets
  • python37Packages.mask-rcnn
  • python37Packages.optuna
  • python37Packages.pymc3
  • python37Packages.rl-coach
  • python37Packages.tensorflow-probability
  • python38Packages.arviz
  • python38Packages.baselines
  • python38Packages.graph_nets
  • python38Packages.mask-rcnn
  • python38Packages.optuna
  • python38Packages.pymc3
  • python38Packages.rl-coach
  • python38Packages.tensorflow-probability
  • python39Packages.baselines
  • python39Packages.edward
  • python39Packages.graph_nets
  • python39Packages.tensorflow
  • python39Packages.tensorflow-build
  • python39Packages.tensorflow-build_2
  • python39Packages.tensorflow-probability
  • python39Packages.tensorflowWithoutCuda
  • python39Packages.tensorflow_2
  • python39Packages.tflearn
15 packages failed to build and are new build failures:
  • bazel-remote: log https://termbin.com/57hm
  • python37Packages.edward: log was empty
  • python37Packages.tensorflow: log was empty
  • (python37Packages.tensorflow-build: log was empty
  • ,python37Packages.tensorflow-build_2: log was empty
  • ,python37Packages.tensorflowWithoutCuda: log was empty
  • ,python37Packages.tensorflow_2): log was empty
  • python37Packages.tflearn: log was empty
  • python38Packages.edward: log was empty
  • python38Packages.tensorflow: log was empty
  • (python38Packages.tensorflow-build: log was empty
  • ,python38Packages.tensorflow-build_2: log was empty
  • ,python38Packages.tensorflowWithoutCuda: log was empty
  • ,python38Packages.tensorflow_2): log was empty
  • python38Packages.tflearn: log was empty

@lukegb
Copy link
Contributor Author

lukegb commented Jan 15, 2021

Hmm, I'm unconvinced by those build failures:

@ofborg build bazel-remote python37Packages.edward python37Packages.tensorflow python37Packages.tflearn python38Packages.edward python38Packages.tensorflow python38Packages.tflearn

@SuperSandro2000
Copy link
Member

Hmm, I'm unconvinced by those build failures:

Bazels is known to not work on darwin.

@lukegb
Copy link
Contributor Author

lukegb commented Jan 16, 2021

Result of nixpkgs-review pr 108741 run on x86_64-linux 1

26 packages marked as broken and skipped:
  • python37Packages.arviz
  • python37Packages.dm-sonnet
  • python37Packages.graph_nets
  • python37Packages.optuna
  • python37Packages.pymc3
  • python37Packages.rl-coach
  • python37Packages.tensorflow-probability
  • python38Packages.arviz
  • python38Packages.dm-sonnet
  • python38Packages.graph_nets
  • python38Packages.optuna
  • python38Packages.pymc3
  • python38Packages.rl-coach
  • python38Packages.tensorflow-probability
  • python39Packages.baselines
  • python39Packages.dm-sonnet
  • python39Packages.edward
  • python39Packages.graph_nets
  • python39Packages.tensorflow
  • python39Packages.tensorflow-build
  • python39Packages.tensorflow-build_2
  • python39Packages.tensorflow-probability
  • python39Packages.tensorflowWithCuda
  • python39Packages.tensorflowWithoutCuda
  • python39Packages.tensorflow_2
  • python39Packages.tflearn
1 package failed to build:
  • tts
16 packages built:
  • bazel-remote
  • bazel-watcher
  • envoy
  • gvisor
  • python37Packages.baselines
  • python37Packages.edward
  • python37Packages.mask-rcnn
  • python37Packages.tensorflow (python37Packages.tensorflow-build ,python37Packages.tensorflow-build_2 ,python37Packages.tensorflowWithoutCuda ,python37Packages.tensorflow_2)
  • python37Packages.tensorflowWithCuda
  • python37Packages.tflearn
  • python38Packages.baselines
  • python38Packages.edward
  • python38Packages.mask-rcnn
  • python38Packages.tensorflow (python38Packages.tensorflow-build ,python38Packages.tensorflow-build_2 ,python38Packages.tensorflowWithoutCuda ,python38Packages.tensorflow_2)
  • python38Packages.tensorflowWithCuda
  • python38Packages.tflearn

@SuperSandro2000
Copy link
Member

tts is broke on master.

SuperSandro2000
SuperSandro2000 approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good

@adisbladis adisbladis merged commit 6dfd1a2 into NixOS:master Jan 19, 2021
@lukegb lukegb deleted the envoy branch January 19, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukegb @SuperSandro2000 @adisbladis