Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tortoisehg: 5.2.1 -> 5.6 #108742

Merged
merged 1 commit into from Jan 8, 2021
Merged

tortoisehg: 5.2.1 -> 5.6 #108742

merged 1 commit into from Jan 8, 2021

Conversation

sheenobu
Copy link
Contributor

@sheenobu sheenobu commented Jan 8, 2021 •
edited

Motivation for this change

Fixes #108740. tortoisehg 5.2.1 used a URL that does not exist and version 5.2.1 never existed as a released version. Additionally, package was out of date/buggy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from danbst January 8, 2021 02:01
@Mic92
Copy link
Member

Mic92 commented Jan 8, 2021

Result of nixpkgs-review pr 108742 run on x86_64-linux 1

1 package built:
  • tortoisehg

@Mic92 Mic92 merged commit d48c4a0 into NixOS:master Jan 8, 2021
@Mic92
Copy link
Member

Mic92 commented Jan 8, 2021 •
edited

Should we just backport it? Sounds like the new version would be more stable.

@sheenobu
Copy link
Contributor Author

Yes i think so. @Mic92 if we backport, would we want 5.6 or 5.4.2?

@Mic92
Copy link
Member

Mic92 commented Jan 12, 2021

Yes i think so. @Mic92 if we backport, would we want 5.6 or 5.4.2?

5.6 sounds easier right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbst danbst Awaiting requested review from danbst

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tortoisehg is out-of-date
2 participants
@sheenobu @Mic92