Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdcat: 0.22.1 -> 0.22.2 #108694

Merged
merged 1 commit into from Jan 7, 2021
Merged

mdcat: 0.22.1 -> 0.22.2 #108694

merged 1 commit into from Jan 7, 2021

Conversation

davidtwco
Copy link
Member

Motivation for this change

Update mdcat to 0.22.2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 108694 run on x86_64-linux 1

1 package built:
  • mdcat

Seems to function as intended.

pkgs/tools/text/mdcat/default.nix
};

nativeBuildInputs = [ pkgconfig asciidoctor installShellFiles ];
buildInputs = [ openssl ] ++ stdenv.lib.optional stdenv.isDarwin Security;

cargoSha256 = "sha256-LoNm2/6/FgTKp95ETODY39D8Ou+9X+IXIy625YW9AFI=";
cargoSha256 = "sha256-mnDUIJhEGNoh3eq2Vhww1T/tpZh9RP+RxbRsBNrpOzw=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note (perhaps for future updates): if a SRI hash is used, you can also use cargoHash.

@danieldk danieldk merged commit e04b99c into NixOS:master Jan 7, 2021
@davidtwco davidtwco deleted the mdcat-0.22.2 branch January 7, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtwco @danieldk