Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyairvisual: 5.0.4 -> 5.0.5 #108677

Merged
merged 3 commits into from Jan 7, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 7, 2021

Motivation for this change

Update to latest upstream release 5.0.5

Change log: https://github.com/bachya/pyairvisual/releases/tag/5.0.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pytestFlagsArray = [
"tests"
];
pytestFlagsArray = [ "tests" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, doesn't pytestCheckHook pick up that directory by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more that I forgot zu update it.

@mweinelt
Copy link
Member

mweinelt commented Jan 7, 2021

python3Packages.pyairvisual: update attributes

This would be the meta attribute set, so update meta would be more fitting.

@fabaff
Copy link
Member Author

fabaff commented Jan 7, 2021

This would be the meta attribute set, so update meta would be more fitting.

Updated

@@ -24,7 +24,7 @@ buildPythonPackage rec {
owner = "bachya";
repo = pname;
rev = version;
sha256 = "0z769xrb6w6bhqcq02sjryl1qyvk9dc1xfn06fc3mdqnrbr0xxj3";
sha256 = "0jjvng3py5g97gvx6rdbk5zxbn5rw8gq1ki4qi4vfsypchxbpz2q";
};

nativeBuildInputs = [ poetry ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an upstream issue to migrate the build-backend to poetry-core. See #103325.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mweinelt
Copy link
Member

mweinelt commented Jan 7, 2021

Result of nixpkgs-review pr 108677 run on x86_64-linux 1

2 packages built:
  • python37Packages.pyairvisual
  • python38Packages.pyairvisual

@mweinelt mweinelt merged commit 2b88da3 into NixOS:master Jan 7, 2021
@fabaff fabaff deleted the bump-pyairvisual branch January 9, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants