Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopls: 0.5.3 -> 0.6.2 #108702

Merged
merged 1 commit into from Jan 7, 2021
Merged

gopls: 0.5.3 -> 0.6.2 #108702

merged 1 commit into from Jan 7, 2021

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jan 7, 2021 •
edited

Motivation for this change

Version bump.

Changelog.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit, zimbatm and Mic92 January 7, 2021 18:11
@zimbatm
Copy link
Member

zimbatm commented Jan 7, 2021

Result of nixpkgs-review pr 108702 run on x86_64-linux 1

2 packages built:
  • gopls
  • vimPlugins.vim-go

@zimbatm zimbatm merged commit d80ba82 into NixOS:master Jan 7, 2021
@asymmetric asymmetric deleted the gopls-0.6.2 branch January 7, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@zimbatm zimbatm Awaiting requested review from zimbatm

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asymmetric @zimbatm