Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.discordpy: remove overly restrictive version constraints #106869

Merged
merged 1 commit into from Dec 21, 2020

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Noticed this failing on Hydra, and fixed it.

I've simply removed any versioning constraints, as we're (AFAIK) choosing these arbitrarily anyway.

This should be backported as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Dec 21, 2020

FYI: Upstream allows now < aiohttp-3.8.0. Unfortunately this change was not released yet.

@fabaff
Copy link
Member

fabaff commented Dec 21, 2020

Result of nixpkgs-review pr 106869 run on x86_64-linux 1

3 packages built:
  • python37Packages.discordpy
  • python38Packages.discordpy
  • python39Packages.discordpy

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 106869 run on x86_64-linux 1

3 packages built:
  • python37Packages.discordpy
  • python38Packages.discordpy
  • python39Packages.discordpy

@jonringer jonringer merged commit b9140da into NixOS:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants