Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.cliff: unbreak build #106866

Closed
wants to merge 1 commit into from

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Noticed this was failing on Hydra, and decided to fix this.
After the issue seen there is fixed, tests still won't work. Some of the hardcoded paths are not even available anymore, others fail not being able to find the which binary, in the cmd2 package.

This should be backported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

I prefer #108977 over this one because it fixes the tests instead of disabling them.

@IvarWithoutBones IvarWithoutBones deleted the fix-cliff branch April 4, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants