New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP: Added SSH2 and msgpack extensions. #106867
Conversation
Hi, do you want to maintain these packages as well as the PHP team? If so you need to make a separate commit to the maintainer list, instructions are in the top of the file. Also, you cleared out the PR template that contains things like checkboxes describing what's been done. That's never a good practice until your request really doesn't match the template, which it does in this case. For instance the commit messages doesn't follow the CONTRIBUTING guidelines. They should be formatted for example: Is it built on Linux? Is it built on Darwin? Just to know where to start testing this. @ofborg build php73Extensions.ssh2 php73Extensions.msgpack php74Extensions.ssh2 php74Extensions.msgpack php80Extensions.ssh2 php80Extensions.msgpack |
I've done some local builds. The following builds on x86_64-linux:
The following doesn't build on x86_64-linux:
Maybe there's some newer version or patch that make it work with PHP 8.0? If not it should be marked as broken on PHP 8.0. |
@ofborg build php73Extensions.ssh2 php73Extensions.msgpack php74Extensions.ssh2 php74Extensions.msgpack php80Extensions.msgpack |
Hi. Thanks for quick response. That's my first PR here. Actually I didn't clear the template. What happened is that for some reason PR when I submitted the PR I got an error that PR already exist. And when I reload the page I saw that PR actually was created. I didn't notice that template was gone. My bad. I'll return the template. |
I'm not a PHP developer myself and added support for the missing extensions we use at work. I'm in frontend team. So I don't see myself maintaining it unless there is a need for me. Hope that's ok. |
I'll do more testing and comeback with new commits. @etu would you like me to rename commits and force push them with correct names? |
That would be great! Thank you in advance :) |
I marked this as stale due to inactivity. → More info |
what's the status of this ? |
Merge conflict and rebase with an update of commit messages to confirm to the https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md guidelines for how the commit messages should be formatted. |
@akoppela Are you going to take care of this? |
This was superseeded by #220814 |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)