Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] tomb: 2.7 -> 2.8.1 #107226

Closed
wants to merge 2 commits into from
Closed

[20.09] tomb: 2.7 -> 2.8.1 #107226

wants to merge 2 commits into from

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented Dec 19, 2020 •
edited by prusnak

Motivation for this change

Fixes #106249.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@amaxine amaxine changed the title 20.09 tomb [20.09] tomb: 2.7 -> 2.8.1 Dec 19, 2020
@prusnak
Copy link
Member

prusnak commented Dec 19, 2020

The PR does not fit CONTRIBUTING.md - backported patches need to be cherry-picked from the master branch using git cherry-pick -x. That also means the PR to master needs to be merged first before doing a backport.

@ofborg ofborg bot requested a review from peterhoeg December 19, 2020 22:52
@amaxine amaxine closed this Dec 19, 2020
@dotlambda
Copy link
Member

second attempt: #110769

@amaxine amaxine deleted the 20.09_tomb branch July 19, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amaxine @prusnak @dotlambda @aaronjanse